ProfileField::all() - Code Metrics - Inspection of "Refactor ActiveRecords, fix caching issues, typos" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c57047...e9f946 )

by Mihail

created 2018-11-27 12:51 UTC

ProfileField::all() A

↳ Parent: ProfileField

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	10
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Apps\ActiveRecord;

use Ffcms\Core\Arch\ActiveModel;
use Ffcms\Core\Cache\MemoryObject;

/**
 * Class ProfileField. Active record model for additional profile fields management
 * @package Apps\ActiveRecord
 * @property int $id
 * @property string $type
 * @property string $name
 * @property string $reg_exp
 * @property string $reg_cond
 * @property string $created_at
 * @property string $updated_at
 */
class ProfileField extends ActiveModel
{
    protected $casts = [
        'id' => 'integer',
        'type' => 'string',
        'name' => 'serialize',
        'reg_exp' => 'string',
        'reg_cond' => 'string'
    ];

    /**
     * Get all table data using memory cache
     * @param array $columns
     * @return \Illuminate\Database\Eloquent\Collection|mixed|static[]
     */
    public static function all($columns = ['*'])
    {
        $cacheName = 'activerecord.profilefield.all.' . implode('.', $columns);
        $records = MemoryObject::instance()->get($cacheName);
        if ($records === null) {
            $records = parent::all($columns);
            MemoryObject::instance()->set($cacheName, $records);
        }

        return $records;
    }

    /**
     * Get field name locale by field id
     * @param int $id
     * @return array|null|string
     */
    public static function getNameById($id)
    {
        $all = self::all();

        $record = $all->find($id);
        if (!$record) {
            return null;
        }

        return $record->getLocaled('name');

    }

    /**
     * Get field type by field id
     * @param int $id
     * @return array|null|string
     */
    public static function getTypeById($id)
    {
        $all = self::all();

        $record = $all->find($id);
        if (!$record) {
            return null;
        }

        return $record->type;
    }
}


1			<?php
2
3			namespace Apps\ActiveRecord;
4
5			use Ffcms\Core\Arch\ActiveModel;
6			use Ffcms\Core\Cache\MemoryObject;
7
8			/**
9			* Class ProfileField. Active record model for additional profile fields management
10			* @package Apps\ActiveRecord
11			* @property int $id
12			* @property string $type
13			* @property string $name
14			* @property string $reg_exp
15			* @property string $reg_cond
16			* @property string $created_at
17			* @property string $updated_at
18			*/
19			class ProfileField extends ActiveModel
20			{
21			protected $casts = [
22			'id' => 'integer',
23			'type' => 'string',
24			'name' => 'serialize',
25			'reg_exp' => 'string',
26			'reg_cond' => 'string'
27			];
28
29			/**
30			* Get all table data using memory cache
31			* @param array $columns
32			* @return \Illuminate\Database\Eloquent\Collection\|mixed\|static[]
33			*/
34			public static function all($columns = ['*'])
35			{
36			$cacheName = 'activerecord.profilefield.all.' . implode('.', $columns);
37			$records = MemoryObject::instance()->get($cacheName);
38			if ($records === null) {
39			$records = parent::all($columns);
40			MemoryObject::instance()->set($cacheName, $records);
41			}
42
43			return $records;
44			}
45
46			/**
47			* Get field name locale by field id
48			* @param int $id
49			* @return array\|null\|string
50			*/
51			public static function getNameById($id)
52			{
53			$all = self::all();
54
55			$record = $all->find($id);
56			if (!$record) {
57			return null;
58			}
59
60			return $record->getLocaled('name');
			0 ignored issues – show Bug Best Practice introduced 2018-11-23 12:45 UTC by Report Bug Copy Issue Report The expression `return $record->getLocaled('name')` also could return the type `Illuminate\Database\Eloquent\Builder` which is incompatible with the documented return type `array\|null\|string`. Loading history...
61			}
62
63			/**
64			* Get field type by field id
65			* @param int $id
66			* @return array\|null\|string
67			*/
68			public static function getTypeById($id)
69			{
70			$all = self::all();
71
72			$record = $all->find($id);
73			if (!$record) {
74			return null;
75			}
76
77			return $record->type;
78			}
79			}
80

phpffcms / ffcms

Push — master ( c57047...e9f946 )

ProfileField::all() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like