Extend\Core\Arch\FrontWidget

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	3
Bugs	3	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	widget()	0	9	2
A	enabled()	0	18	3

<?php
namespace Extend\Core\Arch;

use Ffcms\Core\App;
use Ffcms\Core\Arch\Widget as NativeWidget;
use Apps\ActiveRecord\App as AppRecord;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class FrontWidget. Special controller type for front widgets.
 * @package Extend\Core\Arch
 */
class FrontWidget extends NativeWidget
{
    public static $name;

    /**
     * Display widget compiled data.
     * @param array|null $params
     * @return null|string
     * @throws \Exception
     */
    public static function widget(array $params = null)
    {
        if (!self::enabled()) {

The expression self::enabled() of type null|boolean is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            return null;
        }

        // call parent method
        return parent::widget($params);
    }

    /**
     * Check if widget is enabled
     * @param string|null $name
     * @return bool
     */
    public static function enabled($name = null)

The parameter $name is not used and could be removed.

    {
        // get widget class-namespace callback and single class name
        self::$class = get_called_class();
        self::$name = Str::lastIn(self::$class, '\\', true);

        $wData = AppRecord::getItem('widget', self::$name);

It seems like self::$name can also be of type false; however, Apps\ActiveRecord\App::getItem() does only seem to accept string|array, did you maybe forget to handle an error condition?

        // widget is not founded, deny run
        if ($wData === null) {
            if (App::$Debug !== null) {
                App::$Debug->addMessage(__('Widget with name %name%[%class%] is not found', ['name' => self::$name, 'class' => self::$class]));
            }
            return null;
        }

        // if widget is disabled - lets return nothing
        return !(bool)$wData->disabled;
    }

}