Content::buildSitemapSchedule() - Code Metrics - Inspection of "Acessibility refactoring, fix error in view, etc" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b534e3...17b30a )

by Mihail

created 2018-01-11 16:19 UTC

Content::buildSitemapSchedule() B

↳ Parent: Content

Complexity

Conditions	9
Paths	7

Size

Total Lines	54
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	31
nc	7
nop	0
dl	0
loc	54
rs	7.255
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Apps\Controller\Front;

use Apps\ActiveRecord\Content as ContentEntity;
use Apps\ActiveRecord\Content as ContentRecord;
use Apps\ActiveRecord\ContentCategory;
use Apps\Model\Front\Content\EntityCategoryList;
use Apps\Model\Front\Content\FormNarrowContentUpdate;
use Apps\Model\Front\Sitemap\EntityBuildMap;
use Extend\Core\Arch\FrontAppController;
use Ffcms\Core\App;
use Ffcms\Core\Exception\ForbiddenException;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\FileSystem\File;
use Ffcms\Core\Helper\HTML\SimplePagination;
use Ffcms\Core\Helper\Type\Str;
use Suin\RSSWriter\Channel;
use Suin\RSSWriter\Feed;
use Suin\RSSWriter\Item;

/**
 * Class Content. Controller of content app - content and categories.
 * @package Apps\Controller\Front
 */
class Content extends FrontAppController
{
    const TAG_PER_PAGE = 50;
    const SITEMAP_UPDATE_DELAY = 120; // sitemap update delay in minutes, 120 = 2h
    const SITEMAP_CONTENT_COUNT_ITERATION = 5000; // content count per each one iteration

    const EVENT_CONTENT_READ = 'content.read';
    const EVENT_RSS_READ = 'content.rss.read';
    const EVENT_CONTENT_LIST = 'content.list';
    const EVENT_TAG_LIST = 'content.tags';

    /**
     * Fatty action like actionList(), actionRead() are located in standalone traits.
     * This feature allow provide better read&write accessibility
     */

    use Content\ActionList {
        listing as actionList;
    }

    use Content\ActionRead {
        read as actionRead;
    }

    use Content\ActionUpdate {
        update as actionUpdate;
    }

    use Content\ActionTag {
        tag as actionTag;
    }

    use Content\ActionRss {
        rss as actionRss;
    }

    use Content\ActionMy {
        my as actionMy;
    }

    /**
     * Cron schedule action - build content sitemap
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public static function buildSitemapSchedule()
    {
        // get records from database as activerecord object
        $contents = ContentRecord::where('display', '=', 1);
        $contentCount = $contents->count();
        if ($contentCount < 1) {
            return;
        }

        // get languages if multilanguage enabled
        $langs = null;
        if (App::$Properties->get('multiLanguage')) {
            $langs = App::$Properties->get('languages');
        }

        // build sitemap items using iteration - 5000 rows per each one
        $iterations = (int)($contentCount / static::SITEMAP_CONTENT_COUNT_ITERATION);
        for ($i = 0; $i <= $iterations; $i++) {
            // check if lifetime is expired for current sitemap index
            $xmlTime = File::mTime('/upload/sitemap/content.' . $i . '.' . $langs[0] . '.xml');
            $updateDelay = static::SITEMAP_UPDATE_DELAY * 60;
            $updateDelay += mt_rand(0, 1800); // +- 0-30 rand min for caching update
            // do not process if cache time is not expired
            if (time() - $xmlTime <= $updateDelay) {
                continue;
            }

            // get results with current offset
            $offset = $i * static::SITEMAP_CONTENT_COUNT_ITERATION;
            $result = $contents->take(static::SITEMAP_CONTENT_COUNT_ITERATION)->skip($offset)->get();

            // build sitemap from content items via business model
            $sitemap = new EntityBuildMap($langs);
            foreach ($result as $content) {
                $category = $content->getCategory();
                $uri = '/content/read/';
                if (!Str::likeEmpty($category->path)) {
                    $uri .= $category->path . '/';
                }
                $uri .= $content->path;
                $sitemap->add($uri, $content->created_at, 'weekly', 0.7);
            }
            // add categories
            $categories = ContentCategory::all();
            foreach ($categories as $item) {
                if ((bool)$item->getProperty('showCategory')) {
                    $uri = '/content/list/' . $item->path;
                    $sitemap->add($uri, date('c'), 'daily', 0.9);
                }
            }
            // save data to xml file
            $sitemap->save('content.' . $i);
        }
    }
}


1			<?php
2
3			namespace Apps\Controller\Front;
4
5			use Apps\ActiveRecord\Content as ContentEntity;
6			use Apps\ActiveRecord\Content as ContentRecord;
7			use Apps\ActiveRecord\ContentCategory;
8			use Apps\Model\Front\Content\EntityCategoryList;
9			use Apps\Model\Front\Content\FormNarrowContentUpdate;
10			use Apps\Model\Front\Sitemap\EntityBuildMap;
11			use Extend\Core\Arch\FrontAppController;
12			use Ffcms\Core\App;
13			use Ffcms\Core\Exception\ForbiddenException;
14			use Ffcms\Core\Exception\NotFoundException;
15			use Ffcms\Core\Helper\FileSystem\File;
16			use Ffcms\Core\Helper\HTML\SimplePagination;
17			use Ffcms\Core\Helper\Type\Str;
18			use Suin\RSSWriter\Channel;
19			use Suin\RSSWriter\Feed;
20			use Suin\RSSWriter\Item;
21
22			/**
23			* Class Content. Controller of content app - content and categories.
24			* @package Apps\Controller\Front
25			*/
26			class Content extends FrontAppController
27			{
28			const TAG_PER_PAGE = 50;
29			const SITEMAP_UPDATE_DELAY = 120; // sitemap update delay in minutes, 120 = 2h
30			const SITEMAP_CONTENT_COUNT_ITERATION = 5000; // content count per each one iteration
31
32			const EVENT_CONTENT_READ = 'content.read';
33			const EVENT_RSS_READ = 'content.rss.read';
34			const EVENT_CONTENT_LIST = 'content.list';
35			const EVENT_TAG_LIST = 'content.tags';
36
37			/**
38			* Fatty action like actionList(), actionRead() are located in standalone traits.
39			* This feature allow provide better read&write accessibility
40			*/
41
42			use Content\ActionList {
43			listing as actionList;
44			}
45
46			use Content\ActionRead {
47			read as actionRead;
48			}
49
50			use Content\ActionUpdate {
51			update as actionUpdate;
52			}
53
54			use Content\ActionTag {
55			tag as actionTag;
56			}
57
58			use Content\ActionRss {
59			rss as actionRss;
60			}
61
62			use Content\ActionMy {
63			my as actionMy;
64			}
65
66			/**
67			* Cron schedule action - build content sitemap
68			* @throws \Ffcms\Core\Exception\SyntaxException
69			*/
70			public static function buildSitemapSchedule()
71			{
72			// get records from database as activerecord object
73			$contents = ContentRecord::where('display', '=', 1);
74			$contentCount = $contents->count();
75			if ($contentCount < 1) {
76			return;
77			}
78
79			// get languages if multilanguage enabled
80			$langs = null;
81			if (App::$Properties->get('multiLanguage')) {
82			$langs = App::$Properties->get('languages');
83			}
84
85			// build sitemap items using iteration - 5000 rows per each one
86			$iterations = (int)($contentCount / static::SITEMAP_CONTENT_COUNT_ITERATION);
87			for ($i = 0; $i <= $iterations; $i++) {
88			// check if lifetime is expired for current sitemap index
89			$xmlTime = File::mTime('/upload/sitemap/content.' . $i . '.' . $langs[0] . '.xml');
90			$updateDelay = static::SITEMAP_UPDATE_DELAY * 60;
91			$updateDelay += mt_rand(0, 1800); // +- 0-30 rand min for caching update
92			// do not process if cache time is not expired
93			if (time() - $xmlTime <= $updateDelay) {
94			continue;
95			}
96
97			// get results with current offset
98			$offset = $i * static::SITEMAP_CONTENT_COUNT_ITERATION;
99			$result = $contents->take(static::SITEMAP_CONTENT_COUNT_ITERATION)->skip($offset)->get();
100
101			// build sitemap from content items via business model
102			$sitemap = new EntityBuildMap($langs);
103			foreach ($result as $content) {
104			$category = $content->getCategory();
105			$uri = '/content/read/';
106			if (!Str::likeEmpty($category->path)) {
107			$uri .= $category->path . '/';
108			}
109			$uri .= $content->path;
110			$sitemap->add($uri, $content->created_at, 'weekly', 0.7);
111			}
112			// add categories
113			$categories = ContentCategory::all();
114			foreach ($categories as $item) {
115			if ((bool)$item->getProperty('showCategory')) {
116			$uri = '/content/list/' . $item->path;
117			$sitemap->add($uri, date('c'), 'daily', 0.9);
118			}
119			}
120			// save data to xml file
121			$sitemap->save('content.' . $i);
122			}
123			}
124			}
125

phpffcms / ffcms

Push — master ( b534e3...17b30a )

Content::buildSitemapSchedule() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like