Apps\Controller\Front\Content\ActionRead::read()

Complexity

Conditions	10
Paths	7

Size

Total Lines	57
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function read(): ?string
    {
        // get raw path without controller-action
        $rawPath = $this->request->getPathWithoutControllerAction();
        $arrayPath = explode('/', $rawPath);
        // get category and content item path as string
        $contentPath = array_pop($arrayPath);
        $categoryPath = implode('/', $arrayPath);

        // try to find category object by string pathway
        $categoryRecord = ContentCategory::getByPath($categoryPath);

        // if no categories are available for this path - throw exception
        if (!$categoryRecord || $categoryRecord->count() < 1) {
            throw new NotFoundException(__('Page not found'));
        }

        // try to find content entity record
        $contentRecord = ContentEntity::where('path', '=', $contentPath)
            ->where('category_id', '=', $categoryRecord->id);
        $trash = false;

        // if no entity is founded for this path lets try to find on trashed
        if (!$contentRecord || $contentRecord->count() !== 1) {

$contentRecord is of type Ffcms\Core\Arch\ActiveModel, thus it always evaluated to true.

            // check if user can access to content list on admin panel
            if (!App::$User->isAuth() || !App::$User->identity()->role->can('Admin/Content/Index')) {
                throw new NotFoundException(__('Content not found!'));
            }
            // lets try to find in trashed
            $contentRecord->withTrashed();
            // no way, lets throw exception
            if ($contentRecord->count() !== 1) {
                throw new NotFoundException();
            }
            // set trashed marker for this item
            $trash = true;
        }

        // lets init entity model for content transfer to view
        $model = new EntityContentRead($categoryRecord, $contentRecord->first());

It seems like $categoryRecord can also be of type Illuminate\Support\Collection; however, parameter $category of Apps\Model\Front\Content\EntityContentRead::__construct() does only seem to accept Apps\ActiveRecord\ContentCategory, maybe add an additional type check?

It seems like $contentRecord->first() can also be of type null; however, parameter $content of Apps\Model\Front\Content\EntityContentRead::__construct() does only seem to accept Apps\ActiveRecord\Content, maybe add an additional type check?

        $search = null;
        // check if similar search is enabled for item category
        if ((bool)$model->getCategory()->getProperty('showSimilar') && !$trash) {
            $search = new EntityContentSearch($model->title, $model->id, $model->getCategory()->id);
        }

        // define read event
        App::$Event->run(static::EVENT_CONTENT_READ, [

The constant Apps\Controller\Front\Content\ActionRead::EVENT_CONTENT_READ was not found. Maybe you did not declare it correctly or list all dependencies?

            'model' => $model
        ]);

        // render view output
        return $this->view->render('content/read', [
            'model' => $model,
            'search' => $search,
            'trash' => $trash,
            'configs' => $this->getConfigs()
        ]);