Search::actionIndex() - Code Metrics - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Search::actionIndex() A
last analyzed 2019-02-04 19:14 UTC

↳ Parent: Search

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	20
rs	9.9332
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

namespace Apps\Controller\Admin;

use Apps\Model\Admin\Search\FormSettings;
use Extend\Core\Arch\AdminController;
use Ffcms\Core\App;

/**
 * Class Search. Admin configuration controller for search app.
 * @package Apps\Controller\Admin
 */
class Search extends AdminController
{
    const VERSION = '1.0.1';

    public $type = 'app';

    /**
     * Show search settings
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionIndex()
    {
        // initialize model and pass configs inside
        $model = new FormSettings($this->getConfigs());

        // check if submit request is sended
        if ($model->send()) {
            if ($model->validate()) {
                // save configurations
                $this->setConfigs($model->getAllProperties());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
                $this->response->redirect('search/index');
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render output view
        return $this->view->render('search/settings', [
            'model' => $model
        ]);
    }
}


1			<?php
2
3			namespace Apps\Controller\Admin;
4
5			use Apps\Model\Admin\Search\FormSettings;
6			use Extend\Core\Arch\AdminController;
7			use Ffcms\Core\App;
8
9			/**
10			* Class Search. Admin configuration controller for search app.
11			* @package Apps\Controller\Admin
12			*/
13			class Search extends AdminController
14			{
15			const VERSION = '1.0.1';
16
17			public $type = 'app';
18
19			/**
20			* Show search settings
21			* @return string
22			* @throws \Ffcms\Core\Exception\SyntaxException
23			*/
24			public function actionIndex()
25			{
26			// initialize model and pass configs inside
27			$model = new FormSettings($this->getConfigs());
28
29			// check if submit request is sended
30			if ($model->send()) {
31			if ($model->validate()) {
32			// save configurations
33			$this->setConfigs($model->getAllProperties());
			0 ignored issues – show Bug introduced 2018-08-16 13:25 UTC by Report Bug Copy Issue Report Are you sure the usage of `$model->getAllProperties()` targeting `Ffcms\Core\Arch\Model::getAllProperties()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
34			App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
35			$this->response->redirect('search/index');
36			} else {
37			App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
38			}
39			}
40
41			// render output view
42			return $this->view->render('search/settings', [
43			'model' => $model
44			]);
45			}
46			}
47

phpffcms / ffcms

Search::actionIndex() A last analyzed 2019-02-04 19:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Search::actionIndex() A
last analyzed 2019-02-04 19:14 UTC