Apps\Model\Admin\Application\FormUpdate

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	make()	0	7	1
A	before()	0	20	3
A	__construct()	0	4	1

<?php

namespace Apps\Model\Admin\Application;

use Apps\ActiveRecord\App as AppRecord;
use Ffcms\Core\Arch\Model;
use Ffcms\Core\Exception\ForbiddenException;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Exception\SyntaxException;
use Ffcms\Core\Helper\Date;

/**
 * Class FormUpdate. Process applications and widgets update
 * @package Apps\Model\Admin\Application
 */
class FormUpdate extends Model
{
    public $name;
    public $dbVersion;
    public $scriptVersion;
    public $date;

    /** @var \Apps\ActiveRecord\App $_record */
    private $_record;
    /** @var string $_callback */
    private $_callback;

    /**
     * FormUpdate constructor. Pass app record object inside
     * @param AppRecord $record
     */
    public function __construct(AppRecord $record)
    {
        $this->_record = $record;
        parent::__construct();
    }

    /**
     * Magic method before
     * @throws ForbiddenException
     * @throws NotFoundException
     * @throws SyntaxException
     */
    public function before()
    {
        // get full name of update object
        $class = 'Apps\Controller\Admin\\' . $this->_record->sys_name;
        if (class_exists($class)) {
            $this->_callback = $class;
        } else {
            throw new NotFoundException(__('Admin controller is not founded - %c%', ['c' => $this->_record->sys_name]));
        }

        // compare versions
        if ($this->_record->checkVersion() === true) {
            throw new ForbiddenException('this extension is not able to update - no new version installed');
        }

        // set public attributes to display
        $this->name = $this->_record->getLocaleName();
        $this->dbVersion = $this->_record->version;
        $this->scriptVersion = $this->_record->getScriptVersion();
        $this->date = Date::convertToDatetime($this->_record->updated_at, Date::FORMAT_TO_HOUR);
    }

    /**
     * Make update actions
     */
    public function make()
    {
        // make query to ClassController::update(version)
        @forward_static_call_array([$this->_callback, 'update'], [$this->_record->version]);

It seems like you do not handle an error condition for forward_static_call_array(). This can introduce security issues, and is generally not recommended.

        // update version in db
        $this->_record->version = $this->_record->getScriptVersion();
        $this->_record->save();
    }
}