Completed
Push — master ( 99545e...880d60 )
by Mihail
03:11
created
src/Ffcms/Core/Helper/HTML/Bootstrap/Navbar.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // set mobile collapse id for toggle
38 38
         $mobCollapseId = $elements['collapseId'];
39 39
         if (Str::likeEmpty($mobCollapseId)) {
40
-            $mobCollapseId = Str::randomLatin(mt_rand(6,12)) . mt_rand(1, 99);
40
+            $mobCollapseId = Str::randomLatin(mt_rand(6, 12)).mt_rand(1, 99);
41 41
         }
42 42
 
43 43
         // set element id for toggle
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         // generate output dom of bootstrap navbar
100 100
         $dom = new Dom();
101 101
         $body = $dom->div(function() use ($leftBuild, $rightBuild, $itemsStatic){
102
-            return $leftBuild . $itemsStatic . $rightBuild;
102
+            return $leftBuild.$itemsStatic.$rightBuild;
103 103
         }, ['class' => 'collapse navbar-collapse', 'id' => $mobCollapseId]);
104 104
 
105 105
         // drow <nav @properties>@next</nav>
@@ -110,26 +110,26 @@  discard block
 block discarded – undo
110 110
                 $header = $dom->div(function() use ($dom, $elements, $mobCollapseId){
111 111
                     // drow <button @collapse>@next</button>
112 112
                     $collapseButton = $dom->button(function() use ($dom){
113
-                        $toggleItem = $dom->span(function(){
113
+                        $toggleItem = $dom->span(function() {
114 114
                             return 'Toggle menu';
115 115
                         }, ['class' => 'sr-only']);
116 116
                         $toggleIcon = null;
117 117
                         for ($i = 0; $i < 3; $i++) {
118
-                            $toggleIcon .= $dom->span(function(){
118
+                            $toggleIcon .= $dom->span(function() {
119 119
                                 return null;
120 120
                             }, ['class' => 'icon-bar']);
121 121
                         }
122
-                        return $toggleItem . $toggleIcon;
123
-                    }, ['type' => 'button', 'class' => 'navbar-toggle collapsed', 'data-toggle' => 'collapse', 'data-target' => '#' . $mobCollapseId]);
122
+                        return $toggleItem.$toggleIcon;
123
+                    }, ['type' => 'button', 'class' => 'navbar-toggle collapsed', 'data-toggle' => 'collapse', 'data-target' => '#'.$mobCollapseId]);
124 124
                     // drow <div @brand>@brandtext<?div>
125 125
                     $brand = null;
126 126
                     if (isset($elements['brand'])) {
127 127
                         $brand = Url::link($elements['brand']['link'], $elements['brand']['text'], ['class' => 'navbar-brand']);
128 128
                     }
129
-                    return $collapseButton . $brand;
129
+                    return $collapseButton.$brand;
130 130
                 }, ['class' => 'navbar-header']);
131 131
                 // return header and body concat
132
-                return $header . $body;
132
+                return $header.$body;
133 133
             }, $elements['container']);
134 134
         }, $elements['nav']);
135 135
     }
Please login to merge, or discard this patch.
src/Ffcms/Core/Helper/Type/Str.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@
 block discarded – undo
297 297
 
298 298
         $output = null;
299 299
         foreach ($args as $string) {
300
-            $output .= $string . $separator;
300
+            $output .= $string.$separator;
301 301
         }
302 302
 
303 303
         $output = rtrim($output, $separator);
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -7 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      * @param string $string
69 69
      * @param string $delimiter
70 70
      * @param bool $withoutDelimiter
71
-     * @return string|bool
71
+     * @return false|string
72 72
      */
73 73
     public static function lastIn($string, $delimiter, $withoutDelimiter = false)
74 74
     {
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
 
201 201
     /**
202 202
      * Case-ignore replace $needle to $replacement in string $haystack. Alias for function str_ireplace()
203
-     * @param string|array $needle
204
-     * @param string|array $replacement
203
+     * @param string[] $needle
204
+     * @param string $replacement
205 205
      * @param string $haystack
206 206
      * @return string
207 207
      */
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
     /**
294 294
      * Check is $string sounds like a phone number
295 295
      * @param string $string
296
-     * @return int
296
+     * @return boolean
297 297
      */
298 298
     public static function isPhone($string)
299 299
     {
@@ -302,9 +302,6 @@  discard block
 block discarded – undo
302 302
 
303 303
     /**
304 304
      * Concat string with add string by separator
305
-     * @param string $separator
306
-     * @param string $string1
307
-     * @param string $string2
308 305
      * @return string
309 306
      */
310 307
     public static function concat()
Please login to merge, or discard this patch.
src/Ffcms/Core/I18n/Translate.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
 
116 116
     /**
117 117
      * Get available languages in the filesystem
118
-     * @return array
118
+     * @return string[]
119 119
      */
120 120
     public function getAvailableLangs()
121 121
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
         if (Obj::isArray($params) && count($params) > 0) {
56 56
             foreach ($params as $var => $value) {
57
-                $text = Str::replace('%' . $var . '%', $value, $text);
57
+                $text = Str::replace('%'.$var.'%', $value, $text);
58 58
             }
59 59
         }
60 60
         return $text;
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     public function translate($text, array $params = [])
70 70
     {
71 71
         $index = null;
72
-        $namespace = 'Apps\Controller\\' . env_name . '\\';
72
+        $namespace = 'Apps\Controller\\'.env_name.'\\';
73 73
         foreach (@debug_backtrace() as $caller) {
74 74
             if (isset($caller['class']) && Str::startsWith($namespace, $caller['class'])) {
75 75
                 $index = Str::sub((string)$caller['class'], Str::length($namespace));
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
      */
86 86
     protected function load($index)
87 87
     {
88
-        $file = root . '/I18n/' . env_name . '/' . App::$Request->getLanguage() . '/' . $index . '.php';
88
+        $file = root.'/I18n/'.env_name.'/'.App::$Request->getLanguage().'/'.$index.'.php';
89 89
         if (!File::exist($file)) {
90 90
             return [];
91 91
         }
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     public function getAvailableLangs()
124 124
     {
125 125
         $langs = ['en'];
126
-        $scan = Directory::scan(root . '/I18n/' . env_name . '/', GLOB_ONLYDIR, true);
126
+        $scan = Directory::scan(root.'/I18n/'.env_name.'/', GLOB_ONLYDIR, true);
127 127
         foreach ($scan as $row) {
128 128
             $langs[] = trim($row, '/');
129 129
         }
Please login to merge, or discard this patch.
src/Ffcms/Core/Network/Request.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -59,11 +59,11 @@  discard block
 block discarded – undo
59 59
 
60 60
         $basePath = trim(App::$Properties->get('basePath'), '/');
61 61
         if ($basePath !== null && Str::length($basePath) > 0) {
62
-            $basePath = '/' . $basePath;
62
+            $basePath = '/'.$basePath;
63 63
         }
64 64
 
65 65
         if (!defined('env_no_uri') || env_no_uri === false) {
66
-            $basePath .= '/' . strtolower(env_name);
66
+            $basePath .= '/'.strtolower(env_name);
67 67
         }
68 68
 
69 69
         // we never try to use path's without friendly url's
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             } else {
90 90
                 // try to find language in pathway
91 91
                 foreach (App::$Properties->get('languages') as $lang) {
92
-                    if (Str::startsWith('/' . $lang, $this->getPathInfo())) {
92
+                    if (Str::startsWith('/'.$lang, $this->getPathInfo())) {
93 93
                         $this->language = $lang;
94 94
                         $this->languageInPath = true;
95 95
                     }
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
116 116
                     // parse query string
117 117
                     $queryString = null;
118 118
                     if (count($this->query->all()) > 0) {
119
-                        $queryString = '?' . http_build_query($this->query->all());
119
+                        $queryString = '?'.http_build_query($this->query->all());
120 120
                     }
121 121
 
122 122
                     // build response with redirect to language-based path
123
-                    $response = new Redirect($this->getSchemeAndHttpHost() . $this->basePath . '/' . $userLang . $this->getPathInfo() . $queryString);
123
+                    $response = new Redirect($this->getSchemeAndHttpHost().$this->basePath.'/'.$userLang.$this->getPathInfo().$queryString);
124 124
                     $response->send();
125 125
                     exit();
126 126
                 }
@@ -178,9 +178,9 @@  discard block
 block discarded – undo
178 178
             // find "new path" as binding uri slug
179 179
             $binding = array_search($pathway, $map, true);
180 180
             // build url to redirection
181
-            $url = $this->getSchemeAndHttpHost() . $this->getBasePath() . '/';
181
+            $url = $this->getSchemeAndHttpHost().$this->getBasePath().'/';
182 182
             if (App::$Properties->get('multiLanguage')) {
183
-                $url .= $this->language . '/';
183
+                $url .= $this->language.'/';
184 184
             }
185 185
             $url .= ltrim($binding, '/');
186 186
 
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
     {
271 271
         $route = $this->languageInPath ? Str::sub(parent::getPathInfo(), Str::length($this->language) + 1) : parent::getPathInfo();
272 272
         if (!Str::startsWith('/', $route)) {
273
-            $route = '/' . $route;
273
+            $route = '/'.$route;
274 274
         }
275 275
         return $route;
276 276
     }
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
      */
381 381
     public function getFullUrl()
382 382
     {
383
-        return $this->getSchemeAndHttpHost() . $this->getRequestUri();
383
+        return $this->getSchemeAndHttpHost().$this->getRequestUri();
384 384
     }
385 385
 
386 386
     /**
Please login to merge, or discard this patch.
src/Ffcms/Core/Managers/EventManager.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use Ffcms\Core\App;
5 5
 use Ffcms\Core\Helper\Type\Obj;
6
-use Ffcms\Core\Helper\Type\Str;
7
-use Ffcms\Core\Helper\FileSystem\Directory;
8
-use Ffcms\Core\Helper\FileSystem\File;
9 6
 
10 7
 /**
11 8
  * Class EventManager. Control and run events.
Please login to merge, or discard this patch.
src/Ffcms/Core/Properties.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
46 46
         }
47 47
 
48 48
         // try to load from file
49
-        $configFile = ucfirst(Str::lowerCase($configName)) . '.php';
50
-        if (File::exist('/Private/Config/' . $configFile)) {
51
-            $this->data[$configName] = File::inc('/Private/Config/' . $configFile, true);
49
+        $configFile = ucfirst(Str::lowerCase($configName)).'.php';
50
+        if (File::exist('/Private/Config/'.$configFile)) {
51
+            $this->data[$configName] = File::inc('/Private/Config/'.$configFile, true);
52 52
             return true;
53 53
         }
54 54
 
@@ -139,11 +139,11 @@  discard block
 block discarded – undo
139 139
      */
140 140
     public function writeConfig($configFile, array $data)
141 141
     {
142
-        $path = '/Private/Config/' . ucfirst(Str::lowerCase($configFile)) . '.php';
142
+        $path = '/Private/Config/'.ucfirst(Str::lowerCase($configFile)).'.php';
143 143
         if (!File::exist($path) || !File::writable($path)) {
144 144
             return false;
145 145
         }
146
-        $saveData = '<?php return ' . Arr::exportVar($data) . ';';
146
+        $saveData = '<?php return '.Arr::exportVar($data).';';
147 147
         File::write($path, $saveData);
148 148
         return true;
149 149
     }
Please login to merge, or discard this patch.
src/Ffcms/Core/Managers/CronManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             return false;
77 77
         }
78 78
 
79
-        $callback = (string)$class . '::' . (string)$method;
79
+        $callback = (string)$class.'::'.(string)$method;
80 80
 
81 81
         // add instance to cron task manager
82 82
         if (!isset($this->configs['instances'][$callback])) {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function remove($class, $method)
96 96
     {
97
-        $callback = $class . '::' . $method;
97
+        $callback = $class.'::'.$method;
98 98
         if (isset($this->configs['instances'][$callback])) {
99 99
             unset($this->configs['instances'][$callback], $this->configs['log'][$callback]);
100 100
             App::$Properties->writeConfig('Cron', $this->configs);
Please login to merge, or discard this patch.
src/Ffcms/Core/Helper/HTML/Form.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,8 +103,8 @@
 block discarded – undo
103 103
 
104 104
     /**
105 105
      * Display form field. Allowed type: text, password, textarea, checkbox, select, checkboxes, file, captcha, email, hidden
106
-     * @param $object
107
-     * @param $type
106
+     * @param string $object
107
+     * @param string $type
108 108
      * @param null|array $property
109 109
      * @param null|string $helper
110 110
      * @param null|string $layerFile
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use Ffcms\Core\Exception\NativeException;
7 7
 use Ffcms\Core\Exception\SyntaxException;
8 8
 use Ffcms\Core\Helper\HTML\System\NativeGenerator;
9
-use Ffcms\Core\Helper\Security;
10 9
 use Ffcms\Core\Helper\Type\Arr;
11 10
 use Ffcms\Core\Helper\FileSystem\File;
12 11
 use Ffcms\Core\Helper\Type\Obj;
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     {
82 82
         $form = self::buildSingleTag('form', $this->formProperty, false);
83 83
         if ($this->model->_tokenRequired) {
84
-            $form .= PHP_EOL . $this->field('_csrf_token', 'hidden', ['value' => $this->model->_csrf_token]);
84
+            $form .= PHP_EOL.$this->field('_csrf_token', 'hidden', ['value' => $this->model->_csrf_token]);
85 85
         }
86 86
         return $form;
87 87
     }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     {
102 102
         if ($this->model === null) {
103 103
             if (App::$Debug !== null) {
104
-                App::$Debug->addMessage('Form model is not defined for field name: [' . strip_tags($object) . ']');
104
+                App::$Debug->addMessage('Form model is not defined for field name: ['.strip_tags($object).']');
105 105
             }
106 106
             return null;
107 107
         }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         // check if model contains current tag name as property
116 116
         if (!property_exists($this->model, $propertyName)) {
117 117
             if (App::$Debug !== null) {
118
-                App::$Debug->addMessage('Form field ["' . $object . '"] is not defined in model: [' . get_class($this->model) . ']', 'error');
118
+                App::$Debug->addMessage('Form field ["'.$object.'"] is not defined in model: ['.get_class($this->model).']', 'error');
119 119
             }
120 120
             return null;
121 121
         }
@@ -136,13 +136,13 @@  discard block
 block discarded – undo
136 136
         }
137 137
         
138 138
         // prepare labels text and label "for" attr 
139
-        $labelFor = $this->name . '-' . $propertyName;
139
+        $labelFor = $this->name.'-'.$propertyName;
140 140
         $labelText = $this->model->getLabel($object);
141 141
         $itemValue = $this->model->{$propertyName};
142 142
         // sounds like a dot-separated $object
143 143
         if ($propertyName !== $object) {
144 144
             $nesting = trim(strstr($object, '.'), '.');
145
-            $labelFor .= '-' . Str::replace('.', '-', $nesting);
145
+            $labelFor .= '-'.Str::replace('.', '-', $nesting);
146 146
             $itemValue = Arr::getByPath($nesting, $itemValue);
147 147
         }
148 148
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     public function submitButton($title, array $property = [])
174 174
     {
175 175
         $property['type'] = 'submit';
176
-        $property['name'] = $this->name . '[submit]';
176
+        $property['name'] = $this->name.'[submit]';
177 177
         $property['value'] = $title;
178 178
         return self::buildSingleTag('input', $property);
179 179
     }
@@ -187,10 +187,10 @@  discard block
 block discarded – undo
187 187
     {
188 188
         // pre-validate form fields based on model rules and jquery.validation
189 189
         if ($validate) {
190
-            App::$Alias->addPlainCode('js', '$().ready(function() { $("#' . $this->name . '").validate(); });');
190
+            App::$Alias->addPlainCode('js', '$().ready(function() { $("#'.$this->name.'").validate(); });');
191 191
             App::$Alias->setCustomLibrary('js', '/vendor/bower/jquery-validation/dist/jquery.validate.min.js');
192 192
             if (App::$Request->getLanguage() !== 'en') {
193
-                $localeFile = '/vendor/bower/jquery-validation/src/localization/messages_' . App::$Request->getLanguage() . '.js';
193
+                $localeFile = '/vendor/bower/jquery-validation/src/localization/messages_'.App::$Request->getLanguage().'.js';
194 194
                 if (File::exist($localeFile)) {
195 195
                     App::$Alias->setCustomLibrary('js', $localeFile);
196 196
                 }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
                 $formName = $this->model->getFormName();
202 202
                 if (Obj::isArray($badAttr) && count($badAttr) > 0) {
203 203
                     foreach ($badAttr as $attr) {
204
-                        $itemId = $formName . '-' . $attr;
204
+                        $itemId = $formName.'-'.$attr;
205 205
                         $render = App::$View->render(static::$structLayer['jsnotify'], ['itemId' => $itemId]);
206 206
                         App::$Alias->addPlainCode('js', $render);
207 207
                     }
Please login to merge, or discard this patch.
src/Ffcms/Core/Managers/BootManager.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
         // check if cache is enabled
40 40
         if (App::$Cache !== null) {
41 41
             // try to get bootable class map from cache, or initialize parsing
42
-            if (App::$Cache->get('boot.' . env_name . '.class.map') !== null) {
43
-                $this->objects = App::$Cache->get('boot.' . env_name . '.class.map');
42
+            if (App::$Cache->get('boot.'.env_name.'.class.map') !== null) {
43
+                $this->objects = App::$Cache->get('boot.'.env_name.'.class.map');
44 44
             } else {
45 45
                 $this->compileBootableClasses();
46
-                App::$Cache->set('boot.' . env_name . '.class.map', $this->objects, static::CACHE_TREE_TIME);
46
+                App::$Cache->set('boot.'.env_name.'.class.map', $this->objects, static::CACHE_TREE_TIME);
47 47
             }
48 48
         }
49 49
     }
@@ -89,11 +89,11 @@  discard block
 block discarded – undo
89 89
     {
90 90
         // list app root's
91 91
         foreach ($this->appRoots as $app) {
92
-            $app .= '/Apps/Controller/' . env_name;
92
+            $app .= '/Apps/Controller/'.env_name;
93 93
             $files = File::listFiles($app, ['.php'], true);
94 94
             foreach ($files as $file) {
95 95
                 // define full class name with namespace
96
-                $class = 'Apps\Controller\\' . env_name . '\\' . Str::cleanExtension($file);
96
+                $class = 'Apps\Controller\\'.env_name.'\\'.Str::cleanExtension($file);
97 97
                 // check if class exists (must be loaded over autoloader), boot method exist and this is controller instanceof
98 98
                 if (class_exists($class) && method_exists($class, 'boot') && is_a($class, 'Ffcms\Core\Arch\Controller', true)) {
99 99
                     $this->objects[] = $class;
@@ -103,14 +103,14 @@  discard block
 block discarded – undo
103 103
 
104 104
         // list widget root's
105 105
         foreach ($this->widgetRoots as $widget) {
106
-            $widget .= '/Widgets/' . env_name;
106
+            $widget .= '/Widgets/'.env_name;
107 107
             // widgets are packed in directory, classname should be the same with root directory name
108 108
             $dirs = Directory::scan($widget, GLOB_ONLYDIR, true);
109 109
             if (!Obj::isArray($dirs)) {
110 110
                 continue;
111 111
             }
112 112
             foreach ($dirs as $instance) {
113
-                $class = 'Widgets\\' . env_name . '\\' . $instance . '\\' . $instance;
113
+                $class = 'Widgets\\'.env_name.'\\'.$instance.'\\'.$instance;
114 114
                 if (class_exists($class) && method_exists($class, 'boot') && is_a($class, 'Ffcms\Core\Arch\Widget', true)) {
115 115
                     $this->objects[] = $class;
116 116
                 }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     /**
28 28
      * BootManager constructor. Pass composer loader inside
29
-     * @param bool|object $loader
29
+     * @param boolean $loader
30 30
      */
31 31
     public function __construct($loader = false)
32 32
     {
Please login to merge, or discard this patch.