Widget - Code Metrics - Inspection of "getConfigs method for widgets" - phpffcms/ffcms-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad6dbf...a921a6 )

by Mihail

created 2016-01-26 20:15 UTC

Widget A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	13.46 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	5
Bugs	1	Features	0

Metric	Value
wmc	10
c	5
b	1
f	0
lcom	1
cbo	5
dl	7
loc	52
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
C	widget()	7	30	7
A	getConfigs()	0	5	1
A	display()	0	1	1
A	init()	0	1	1

How to fix Duplicated Code

<?php

namespace Ffcms\Core\Arch;

use Apps\ActiveRecord\App as AppRecord;
use Ffcms\Core\App;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Helper\Type\Str;
use Ffcms\Core\Interfaces\iWidget;
use Ffcms\Core\Traits\DynamicGlobal;

/**
 * Class Widget. Provide constructor to work with widget-type based extensions for ffcms.
 * @package Ffcms\Core\Arch
 */
class Widget implements iWidget
{
    use DynamicGlobal;

    /** @var string|null */
    public static $class;

    public static function widget(array $params = null)

    {
        self::$class = get_called_class();

        // check if class exist
        if (!class_exists(self::$class)) {
            return 'Error: Widget is not founded: ' . App::$Security->strip_tags(self::$class);
        }

        // init class and pass properties
        $object = new self::$class;
        if (Obj::isArray($params) && count($params) > 0) {

            foreach ($params as $property => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                if (property_exists($object, $property)) {
                    $object->$property = $value;
                }
            }
        }

        // prepare output
        $out = null;
        try {
            $object->init();
            $out = $object->display();
        } catch (\Exception $e) {
            throw $e;
        }

        return $out;
    }

    /**
     * Get widget configs from admin part as array $cfg=>$value
     * @return array|null|string
     */
    public function getConfigs()
    {
        $realName = Str::lastIn(self::$class, '\\', true);
        return AppRecord::getConfigs('widget', $realName);
    }

    public function display() {}
    public function init() {}

}

1		<?php
2
3		namespace Ffcms\Core\Arch;
4
5		use Apps\ActiveRecord\App as AppRecord;
6		use Ffcms\Core\App;
7		use Ffcms\Core\Helper\Type\Obj;
8		use Ffcms\Core\Helper\Type\Str;
9		use Ffcms\Core\Interfaces\iWidget;
10		use Ffcms\Core\Traits\DynamicGlobal;
11
12		/**
13		* Class Widget. Provide constructor to work with widget-type based extensions for ffcms.
14		* @package Ffcms\Core\Arch
15		*/
16		class Widget implements iWidget
17		{
18		use DynamicGlobal;
19
20		/** @var string\|null */
21		public static $class;
22
23		public static function widget(array $params = null)
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-21 16:41 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
24		{
25		self::$class = get_called_class();
26
27		// check if class exist
28		if (!class_exists(self::$class)) {
29		return 'Error: Widget is not founded: ' . App::$Security->strip_tags(self::$class);
30		}
31
32		// init class and pass properties
33		$object = new self::$class;
34	View Code Duplication	if (Obj::isArray($params) && count($params) > 0) {
		0 ignored issues – show Duplication introduced 2015-12-11 09:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		foreach ($params as $property => $value) {
		0 ignored issues – show Bug introduced 2015-11-21 16:41 UTC by Report Bug Copy Issue Report The expression `$params` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
36		if (property_exists($object, $property)) {
37		$object->$property = $value;
38		}
39		}
40		}
41
42		// prepare output
43		$out = null;
44		try {
45		$object->init();
46		$out = $object->display();
47		} catch (\Exception $e) {
48		throw $e;
49		}
50
51		return $out;
52		}
53
54		/**
55		* Get widget configs from admin part as array $cfg=>$value
56		* @return array\|null\|string
57		*/
58		public function getConfigs()
59		{
60		$realName = Str::lastIn(self::$class, '\\', true);
61		return AppRecord::getConfigs('widget', $realName);
62		}
63
64		public function display() {}
65		public function init() {}
66
67		}

phpffcms / ffcms-core

Push — master ( ad6dbf...a921a6 )

Widget A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like