Ffcms\Core\Arch\Widget

Complexity

Total Complexity

10

Size/Duplication

Total Lines	44
Duplicated Lines	15.91 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
C	widget()	7	32	8
A	display()	0	1	1
A	init()	0	1	1

<?php

namespace Ffcms\Core\Arch;

use Ffcms\Core\App;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Interfaces\iWidget;
use Ffcms\Core\Traits\DynamicGlobal;

abstract class Widget implements iWidget
{
    use DynamicGlobal;

    /** @var string|null */
    public static $class;

    public static function widget(array $params = null)

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        if (self::$class === null) {
            self::$class = get_called_class();
        }

        // check if class exist
        if (!class_exists(self::$class)) {
            return 'Error: Widget is not founded: ' . App::$Security->strip_tags(self::$class);
        }

        // init class and pass properties
        $object = new self::$class;
        if (Obj::isArray($params) && count($params) > 0) {

This code seems to be duplicated across your project.

            foreach ($params as $property => $value) {

The expression $params of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                if (property_exists($object, $property)) {
                    $object->$property = $value;
                }
            }
        }

        // prepare output
        $out = null;
        try {
            $object->init();
            $out = $object->display();
        } catch (\Exception $e) {
            throw $e;
        }

        return $out;
    }

    public function display() {}
    public function init() {}

}