Ffcms\Core\Arch\Widget

Complexity

Total Complexity

11

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	6
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfigs()	0	5	1
A	display()	0	1	1
A	init()	0	1	1
C	widget()	0	30	7
A	enabled()	0	4	1

<?php

namespace Ffcms\Core\Arch;

use Apps\ActiveRecord\App as AppRecord;
use Ffcms\Core\App;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Helper\Type\Str;
use Ffcms\Core\Interfaces\iWidget;
use Ffcms\Core\Traits\DynamicGlobal;

/**
 * Class Widget. Provide constructor to work with widget-type based extensions for ffcms.
 * @package Ffcms\Core\Arch
 */
class Widget implements iWidget
{
    use DynamicGlobal;

    /** @var string|null */
    public static $class;

    public static function widget(array $params = null)

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        self::$class = get_called_class();

        // check if class exist
        if (!class_exists(self::$class)) {
            return 'Error: Widget is not founded: ' . App::$Security->strip_tags(self::$class);
        }

        // init class and pass properties
        $object = new self::$class;
        if (Obj::isArray($params) && count($params) > 0) {
            foreach ($params as $property => $value) {

The expression $params of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                if (property_exists($object, $property)) {
                    $object->$property = $value;
                }
            }
        }

        // prepare output
        $out = null;
        try {
            $object->init();
            $out = $object->display();
        } catch (\Exception $e) {
            throw $e;
        }

        return $out;
    }

    /**
     * Get widget configs from admin part as array $cfg=>$value
     * @return array|null|string
     */
    public function getConfigs()
    {
        $realName = Str::lastIn(self::$class, '\\', true);
        return AppRecord::getConfigs('widget', $realName);
    }

    public function display() {}
    public function init() {}

    /**
     * Check if widget is enabled. For native widget is always enabled
     * @param string $name
     * @return bool
     */
    public static function enabled($name)

The parameter $name is not used and could be removed.

    {
        return true;
    }
}