Ffcms\Core\Helper\Environment::loadAverage()

Complexity

Conditions	7
Paths	10

Size

Total Lines	28
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function loadAverage()
    {
        $load = 0;
        if (stristr(PHP_OS, 'win')) {
            // its not a better solution, but no other way to do this
            $cmd = "wmic cpu get loadpercentage /all";
            @exec($cmd, $output);

It seems like you do not handle an error condition for exec(). This can introduce security issues, and is generally not recommended.

            // if output is exist
            if ($output) {
                // try to find line with numeric data
                foreach ($output as $line) {
                    if ($line && preg_match("/^[0-9]+\$/", $line)) {
                        $load = $line;
                        break;
                    }
                }
            }
        } else {
            $sys_load = sys_getloadavg(); // get linux load average (1 = 100% of 1 CPU)
            $load = $sys_load[0] * 100; // to percentage
        }

        if ((int)$load <= 0) {
            return 'error';
        }

        return (int)$load . '%';
    }