Ffcms\Core\Helper\Simplify

Complexity

Total Complexity

6

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	parseUserNick()	0	14	3
A	parseUserLink()	0	9	3

<?php

namespace Ffcms\Core\Helper;

use Ffcms\Core\App;
use Ffcms\Core\Helper\Type\Any;
use Ffcms\Templex\Url\Url;

The type Ffcms\Templex\Url\Url was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * Class Simplify. Simplification of ofter used logic and methods.
 * @package Ffcms\Core\Helper
 */
class Simplify
{
    /**
     * Get user nickname by user id with predefined value on empty or not exist profile
     * @param $userId
     * @param string $onEmpty
     * @return string
     */
    public static function parseUserNick($userId = null, $onEmpty = 'guest'): ?string
    {
        if (!Any::isInt($userId)) {
            return \App::$Security->strip_tags($onEmpty);

The property Security does not seem to exist on Illuminate\Support\Facades\App.

        }

        // try to find user active record as object
        $identity = App::$User->identity($userId);
        if (!$identity) {
            return \App::$Security->strip_tags($onEmpty);
        }

        // return user nickname from profile
        return $identity->profile->getNickname();

Accessing profile on the interface Ffcms\Core\Interfaces\iUser suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * Prepare HTML DOM link (a href) to user with him name or guest name without link
     * @param int $userId
     * @param string $onEmpty
     * @param string $controllerAction
     * @return string
     */
    public static function parseUserLink($userId = null, $onEmpty = 'guest', $controllerAction = 'profile/show')
    {
        $nick = self::parseUserNick($userId, $onEmpty);
        // new name is not found, lets return default
        if ($nick === $onEmpty || (int)$userId < 1) {
            return $nick;
        }

        return Url::a([$controllerAction, [(int)$userId]], $nick);
    }
}