PHPExtra\Sorter\Comparator\UnicodeComparator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	getLocale()	0	4	1
A	compare()	0	6	2
A	supports()	0	4	4

<?php

namespace PHPExtra\Sorter\Comparator;

/**
 * Case-sensitive multibyte string comparison
 * This comparator uses Collator object from INTL with Collator::NUMERIC_COLLATION flag set to TRUE.
 *
 * @see Collator::NUMERIC_COLLATION
 * @author Jacek Kobus <kobus.jacek@gmail.com>
 */
class UnicodeComparator implements ComparatorInterface
{
    /**
     * @var \Collator
     */
    private $collator;

    /**
     * @param string $locale
     */
    function __construct($locale = null)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if(!$locale){

The expression $locale of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $locale = \Locale::getDefault();
        }
        $this->collator = new \Collator($locale);
        $this->collator->setAttribute(\Collator::NUMERIC_COLLATION, \Collator::ON);
    }

    /**
     * Get locale used by collator
     *
     * @return string
     */
    public function getLocale()
    {
        return $this->collator->getLocale(\Locale::VALID_LOCALE);
    }

    /**
     * {@inheritdoc}
     */
    public function compare($a, $b)
    {
        //@todo result can be false in case of an error - lets pretend that those strings are equal for now
        $result = $this->collator->compare($a, $b);
        return $result !== false ? $result : 0;
    }

    /**
     * {@inheritdoc}
     */
    public function supports($value)
    {
        return $value === null || is_string($value) || is_int($value) || is_float($value);
    }
}