Issues in Song.php (master) - Issues in master - phpdish/PHPDishDailySongPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

src/Entity/Song.php (1 issue)

Labels

Severity

Major 1

<?php

namespace PHPDish\DailySongPlugin\Entity;

use Carbon\Carbon;
use PHPDish\Bundle\CoreBundle\Model\DateTimeTrait;
use PHPDish\Bundle\CoreBundle\Model\EnabledTrait;
use PHPDish\Bundle\CoreBundle\Model\IdentifiableTrait;
use PHPDish\DailySongPlugin\Model\SongInterface;

class Song implements SongInterface
{
    use IdentifiableTrait;
    use DateTimeTrait;
    use EnabledTrait;

    /**
     * @var string
     */
    protected $name;

    /**
     * @var string
     */
    protected $srcId;

    /**
     * @var string
     */
    protected $src;

    public function __construct()
    {
        $this->createdAt = $this->updatedAt = Carbon::now();
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * {@inheritdoc}
     */
    public function setName($name)
    {
        $this->name = $name;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getSrcId()
    {
        return $this->srcId;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function setSrcId($srcId)
    {
        $this->srcId = $srcId;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getSrc()
    {
        return $this->src;
    }

    /**
     * {@inheritdoc}
     */
    public function setSrc($src)
    {
        $this->src = $src;

        return $this;
    }
}

1			<?php
2
3			namespace PHPDish\DailySongPlugin\Entity;
4
5			use Carbon\Carbon;
6			use PHPDish\Bundle\CoreBundle\Model\DateTimeTrait;
7			use PHPDish\Bundle\CoreBundle\Model\EnabledTrait;
8			use PHPDish\Bundle\CoreBundle\Model\IdentifiableTrait;
9			use PHPDish\DailySongPlugin\Model\SongInterface;
10
11			class Song implements SongInterface
12			{
13			use IdentifiableTrait;
14			use DateTimeTrait;
15			use EnabledTrait;
16
17			/**
18			* @var string
19			*/
20			protected $name;
21
22			/**
23			* @var string
24			*/
25			protected $srcId;
26
27			/**
28			* @var string
29			*/
30			protected $src;
31
32			public function __construct()
33			{
34			$this->createdAt = $this->updatedAt = Carbon::now();
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			public function getName()
41			{
42			return $this->name;
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function setName($name)
49			{
50			$this->name = $name;
51
52			return $this;
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function getSrcId()
59			{
60			return $this->srcId;
			0 ignored issues – show Bug Best Practice introduced 2018-03-19 07:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this->srcId` returns the type `string` which is incompatible with the return type mandated by `PHPDish\DailySongPlugin\...ngInterface::getSrcId()` of `integer\|double`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
61			}
62
63			/**
64			* {@inheritdoc}
65			*/
66			public function setSrcId($srcId)
67			{
68			$this->srcId = $srcId;
69
70			return $this;
71			}
72
73			/**
74			* {@inheritdoc}
75			*/
76			public function getSrc()
77			{
78			return $this->src;
79			}
80
81			/**
82			* {@inheritdoc}
83			*/
84			public function setSrc($src)
85			{
86			$this->src = $src;
87
88			return $this;
89			}
90			}

phpdish / PHPDishDailySongPlugin

Issues (8)

src/Entity/Song.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like