phpcollective / menumaker

src/Http/Controllers/SectionController.php

<?php

namespace PhpCollective\MenuMaker\Http\Controllers;

use Illuminate\Routing\Controller;
use PhpCollective\MenuMaker\Storage\Menu;
use PhpCollective\MenuMaker\Http\Requests\MenuRequest as Request;

class SectionController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $sections = Menu::sections()->paginate();
        return view('menu-maker::sections.index', compact('sections'));

The expression return view('menu-maker::sections.index', compact('sections')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('menu-maker::sections.create');

The expression return view('menu-maker::sections.create') returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  Request $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        Menu::create($request->only('name', 'alias'));
        return redirect()

The expression return redirect()->route('menu-maker::sections.index')->withMessage(__('menu-maker::alerts.created', array('name' => $request->name))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->route('menu-maker::sections.index')
            ->withMessage(__('menu-maker::alerts.created', ['name' => $request->name]));
    }

    /**
     * Display the specified resource.
     *
     * @param  Menu $section
     * @return \Illuminate\Http\Response
     */
    public function show(Menu $section)
    {
        return view('menu-maker::sections.show', compact('section'));

The expression return view('menu-maker::sections.show', compact('section')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  Menu $section
     * @return \Illuminate\Http\Response
     */
    public function edit(Menu $section)
    {
        return view('menu-maker::sections.edit', compact('section'));

The expression return view('menu-maker::sections.edit', compact('section')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Request $request
     * @param  Menu $section
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Menu $section)
    {
        $section->update($request->all());
        return redirect()

The expression return redirect()->to($request->redirects_to)->withMessage(__('menu-maker::alerts.updated', array('name' => $request->name))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->to($request->redirects_to)
            ->withMessage(__('menu-maker::alerts.updated', ['name' => $request->name]));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  Menu $section
     * @return \Illuminate\Http\Response
     */
    public function destroy(Menu $section)
    {
        $name = $section->name;
        $section->delete();
        return redirect()

The expression return redirect()->to(request('redirects_to'))->withMessage(__('menu-maker::alerts.deleted', array('name' => $name))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->to(request('redirects_to'))

It seems like request('redirects_to') can also be of type array; however, parameter $path of Illuminate\Routing\Redirector::to() does only seem to accept string, maybe add an additional type check?

            ->withMessage(__('menu-maker::alerts.deleted', ['name' => $name]));
    }
}