phpcollective / menumaker

src/Http/Controllers/RoleController.php

<?php

namespace PhpCollective\MenuMaker\Http\Controllers;

use Illuminate\Routing\Controller;
use PhpCollective\MenuMaker\Storage\Menu;
use PhpCollective\MenuMaker\Storage\Role;
use PhpCollective\MenuMaker\Jobs\RemoveUserMenuCache;
use PhpCollective\MenuMaker\Http\Requests\MenuRoleRequest;
use PhpCollective\MenuMaker\Http\Requests\RoleRequest as Request;

class RoleController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $roles = Role::withoutGlobalScopes()->paginate();
        return view('menu-maker::roles.index', compact('roles'));

The expression return view('menu-maker::roles.index', compact('roles')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('menu-maker::roles.create');

The expression return view('menu-maker::roles.create') returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        Role::create($request->all());
        return redirect()

The expression return redirect()->route('menu-maker::roles.index')->withMessage(__('menu-maker::alerts.created', array('name' => $request->name))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->route('menu-maker::roles.index')
            ->withMessage(__('menu-maker::alerts.created', ['name' => $request->name]));
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $role = Role::withoutGlobalScopes()->findOrFail($id);
        return view('menu-maker::roles.show', compact('role'));

The expression return view('menu-maker::roles.show', compact('role')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $role = Role::withoutGlobalScopes()->findOrFail($id);
        return view('menu-maker::roles.edit', compact('role'));

The expression return view('menu-maker::roles.edit', compact('role')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Request  $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $role = Role::withoutGlobalScopes()->findOrFail($id);
        $role->update($request->all());
        return redirect()

The expression return redirect()->to($request->redirects_to)->withMessage(__('menu-maker::alerts.updated', array('name' => $request->name))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->to($request->redirects_to)
            ->withMessage(__('menu-maker::alerts.updated', ['name' => $request->name]));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $role = Role::withoutGlobalScopes()->findOrFail($id);
        $name = $role->name;
        $users = $role->users()->count();
        if ($users > 0) {
            return redirect()

The expression return redirect()->to(request('redirects_to'))->withErrors(__($name . ' role has ' . $users . ' active user(s).')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                ->to(request('redirects_to'))

It seems like request('redirects_to') can also be of type array; however, parameter $path of Illuminate\Routing\Redirector::to() does only seem to accept string, maybe add an additional type check?

                ->withErrors(__($name . ' role has ' . $users . ' active user(s).'));
        }
        
        $role->delete();
        return redirect()

The expression return redirect()->to(request('redirects_to'))->withMessage(__('menu-maker::alerts.deleted', array('name' => $name))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->to(request('redirects_to'))
            ->withMessage(__('menu-maker::alerts.deleted', ['name' => $name]));
    }

    public function menus()
    {
        $roles = Role::admin(false)->pluck('name', 'id');
        $sections = Menu::sections()->pluck('name', 'id');
        return view('menu-maker::roles.menus', compact('roles', 'sections'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param MenuRoleRequest $request
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     */
    public function assign(MenuRoleRequest $request)
    {
        $role = Role::findOrFail($request->role_id);
        $previous_ids = $role->menus()->descendantsOf($request->section_id)->pluck('id')->toArray();
        if(count($previous_ids) > 0)
        {
            $role->menus()->detach($previous_ids);
        }
        $role->menus()->attach($request->menu_ids);

        $role->users->each(function ($user) {

The property users does not seem to exist on PhpCollective\MenuMaker\Storage\Role. Are you sure there is no database migration missing?

            RemoveUserMenuCache::dispatch($user);
        });

        return redirect()
            ->back()
            ->withMessage(__('menu-maker::alerts.updated', ['name' => $role->name]));
    }
}