NumerosPedimentoAduana::create() - Code Metrics - Inspection of "Cfdi 40" - phpcfdi/sat-catalogos - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

by Carlos C

created 2022-06-15 18:36 UTC

NumerosPedimentoAduana::create() A

↳ Parent: NumerosPedimentoAduana

Complexity

Conditions	3
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	9
ccs	8
cts	8
cp	1
crap	3
rs	10

<?php

declare(strict_types=1);

namespace PhpCfdi\SatCatalogos\CFDI40;

use PhpCfdi\SatCatalogos\Common\BaseCatalog;
use PhpCfdi\SatCatalogos\Common\BaseCatalogTrait;
use PhpCfdi\SatCatalogos\Repository;

class NumerosPedimentoAduana implements BaseCatalog
{
    use BaseCatalogTrait;

    public function obtain(string $aduana, string $patente, int $ejercicio): NumeroPedimentoAduana
    {
        $data = $this->repository()->queryRowByFields(Repository::CFDI_40_NUMEROS_PEDIMENTO_ADUANA, [
            'aduana' => $aduana,
            'patente' => $patente,
            'ejercicio' => $ejercicio,
        ]);
        return $this->create($data);
    }

    /**
     * @param array<string, mixed> $data
     * @return NumeroPedimentoAduana
     */
    public function create(array $data): NumeroPedimentoAduana
    {
        return new NumeroPedimentoAduana(
            (string) $data['aduana'],
            (string) $data['patente'],
            (int) $data['ejercicio'],
            (int) $data['cantidad'],
            ($data['vigencia_desde']) ? strtotime($data['vigencia_desde']) : 0,
            ($data['vigencia_hasta']) ? strtotime($data['vigencia_hasta']) : 0
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpCfdi\SatCatalogos\CFDI40;
6
7		use PhpCfdi\SatCatalogos\Common\BaseCatalog;
8		use PhpCfdi\SatCatalogos\Common\BaseCatalogTrait;
9		use PhpCfdi\SatCatalogos\Repository;
10
11		class NumerosPedimentoAduana implements BaseCatalog
12		{
13		use BaseCatalogTrait;
14
15	2	public function obtain(string $aduana, string $patente, int $ejercicio): NumeroPedimentoAduana
16		{
17	2	$data = $this->repository()->queryRowByFields(Repository::CFDI_40_NUMEROS_PEDIMENTO_ADUANA, [
18		'aduana' => $aduana,
19		'patente' => $patente,
20		'ejercicio' => $ejercicio,
21		]);
22	2	return $this->create($data);
23		}
24
25		/**
26		* @param array<string, mixed> $data
27		* @return NumeroPedimentoAduana
28		*/
29	3	public function create(array $data): NumeroPedimentoAduana
30		{
31	3	return new NumeroPedimentoAduana(
32	3	(string) $data['aduana'],
33	3	(string) $data['patente'],
34	3	(int) $data['ejercicio'],
35	3	(int) $data['cantidad'],
36	3	($data['vigencia_desde']) ? strtotime($data['vigencia_desde']) : 0,
37	3	($data['vigencia_hasta']) ? strtotime($data['vigencia_hasta']) : 0
38		);
39		}
40		}
41

phpcfdi / sat-catalogos

Pull Request — master (#14)

NumerosPedimentoAduana::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like