Bancos::create() - Code Metrics - Inspection of "Adding Nomina Catalogs" - phpcfdi/sat-catalogos - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

unknown

created 2021-03-23 14:41 UTC

Bancos::create() A

↳ Parent: Bancos

Complexity

Conditions	3
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	1
nop	1
dl	0
loc	8
ccs	7
cts	7
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace PhpCfdi\SatCatalogos\Nomina;

use PhpCfdi\SatCatalogos\Common\AbstractCatalogIdentifiable;
use PhpCfdi\SatCatalogos\Common\EntryIdentifiable;
use PhpCfdi\SatCatalogos\Repository;

/**
 * Catálogo de Bancos
 * @method Banco obtain(string $id)
 */
class Bancos extends AbstractCatalogIdentifiable
{
    protected function catalogName(): string
    {
        return Repository::NOMINA_BANCOS;
    }

    /**
     * @param array<string, mixed> $data
     * @return Banco
     */
    public function create(array $data): EntryIdentifiable
    {
        return new Banco(
            $data['id'],
            $data['texto'],
            $data['razon_social'],
            ($data['vigencia_desde']) ? strtotime($data['vigencia_desde']) : 0,
            ($data['vigencia_hasta']) ? strtotime($data['vigencia_hasta']) : 0
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpCfdi\SatCatalogos\Nomina;
6
7		use PhpCfdi\SatCatalogos\Common\AbstractCatalogIdentifiable;
8		use PhpCfdi\SatCatalogos\Common\EntryIdentifiable;
9		use PhpCfdi\SatCatalogos\Repository;
10
11		/**
12		* Catálogo de Bancos
13		* @method Banco obtain(string $id)
14		*/
15		class Bancos extends AbstractCatalogIdentifiable
16		{
17	1	protected function catalogName(): string
18		{
19	1	return Repository::NOMINA_BANCOS;
20		}
21
22		/**
23		* @param array<string, mixed> $data
24		* @return Banco
25		*/
26	2	public function create(array $data): EntryIdentifiable
27		{
28	2	return new Banco(
29	2	$data['id'],
30	2	$data['texto'],
31	2	$data['razon_social'],
32	2	($data['vigencia_desde']) ? strtotime($data['vigencia_desde']) : 0,
33	2	($data['vigencia_hasta']) ? strtotime($data['vigencia_hasta']) : 0
34		);
35		}
36		}
37

phpcfdi / sat-catalogos

Pull Request — master (#11)

Bancos::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like