TiposComprobantes::create() - Code Metrics - Inspection of "Cfdi 40" - phpcfdi/sat-catalogos - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

by Carlos C

created 2022-06-16 02:29 UTC

TiposComprobantes::create() A

↳ Parent: TiposComprobantes

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	7
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	9
ccs	8
cts	8
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

namespace PhpCfdi\SatCatalogos\CFDI40;

use PhpCfdi\SatCatalogos\Common\AbstractCatalogIdentifiable;
use PhpCfdi\SatCatalogos\Common\EntryIdentifiable;
use PhpCfdi\SatCatalogos\Helpers\ScalarValues;
use PhpCfdi\SatCatalogos\Repository;

/**
 * Catálogo de Tipos de comprobante
 * @method TipoComprobante obtain(string $id)
 */
class TiposComprobantes extends AbstractCatalogIdentifiable
{
    protected function catalogName(): string
    {
        return Repository::CFDI_40_TIPOS_COMPROBANTES;
    }

    /**
     * @param array<string, scalar> $data
     * @return TipoComprobante
     */
    public function create(array $data): EntryIdentifiable
    {
        $values = new ScalarValues($data);
        return new TipoComprobante(
            $values->string('id'),
            $values->string('texto'),
            $values->string('valor_maximo'),
            $values->timestamp('vigencia_desde'),
            $values->timestamp('vigencia_hasta'),
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpCfdi\SatCatalogos\CFDI40;
6
7		use PhpCfdi\SatCatalogos\Common\AbstractCatalogIdentifiable;
8		use PhpCfdi\SatCatalogos\Common\EntryIdentifiable;
9		use PhpCfdi\SatCatalogos\Helpers\ScalarValues;
10		use PhpCfdi\SatCatalogos\Repository;
11
12		/**
13		* Catálogo de Tipos de comprobante
14		* @method TipoComprobante obtain(string $id)
15		*/
16		class TiposComprobantes extends AbstractCatalogIdentifiable
17		{
18	1	protected function catalogName(): string
19		{
20	1	return Repository::CFDI_40_TIPOS_COMPROBANTES;
21		}
22
23		/**
24		* @param array<string, scalar> $data
25		* @return TipoComprobante
26		*/
27	2	public function create(array $data): EntryIdentifiable
28		{
29	2	$values = new ScalarValues($data);
30	2	return new TipoComprobante(
31	2	$values->string('id'),
32	2	$values->string('texto'),
33	2	$values->string('valor_maximo'),
34	2	$values->timestamp('vigencia_desde'),
35	2	$values->timestamp('vigencia_hasta'),
36		);
37		}
38		}
39

phpcfdi / sat-catalogos

Pull Request — master (#14)

TiposComprobantes::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like