PhpCfdi\RfcLinc\DataGateway\Pdo\AbstractPdoGateway

Complexity

Total Complexity

10

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

84%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	preparedStatements()	0	14	3
A	queryValue()	0	9	3
A	executePrepared()	0	9	3

<?php

declare(strict_types=1);

namespace PhpCfdi\RfcLinc\DataGateway\Pdo;

use PDO;
use PDOStatement;
use PhpCfdi\RfcLinc\DataGateway\PersistenceException;

abstract class AbstractPdoGateway
{
    /** @var PDO */
    private $pdo;

    /** @var PDOStatement[] */
    private $preparedStatements;

    public function __construct(PDO $pdo)
    {
        $this->pdo = $pdo;
        $this->preparedStatements = [];
    }

    public function preparedStatements(string $query): PDOStatement
    {
        $statement = $this->preparedStatements[$query] ?? null;
        if ($statement instanceof PDOStatement) {
            return $statement;
        }

        $statement = $this->pdo->prepare($query);
        if (false === $statement) {
            throw new \LogicException("Cannot prepare the statement: $query");
        }
        $this->preparedStatements[$query] = $statement;

        return $statement;

The expression return $statement could return the type true which is incompatible with the type-hinted return PDOStatement. Consider adding an additional type-check to rule them out.

    }

    public function executePrepared(string $query, array $arguments = [], string $exceptionMessage = ''): PDOStatement
    {
        $statement = $this->preparedStatements($query);
        if (! $statement->execute($arguments)) {
            $exceptionMessage = $exceptionMessage ? : 'Error retrieving data from database';
            throw new PersistenceException($exceptionMessage);
        }

        return $statement;
    }

    public function queryValue(string $query, array $arguments = [], $defaultValue = null)
    {
        $stmt = $this->executePrepared($query, $arguments);
        $values = $stmt->fetch(PDO::FETCH_NUM);
        if (is_array($values) && array_key_exists(0, $values)) {
            return $values[0];
        }

        return $defaultValue;
    }
}