StampService::stamp() - Code Metrics - Inspection of "Revert "Merge pull request #7 from eclipxe13/maste..." - phpcfdi/finkok - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Carlos C

created 2019-10-03 01:25 UTC

StampService::stamp() A

↳ Parent: StampService

Complexity

Conditions	4
Paths	2

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.3244

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	4
eloc	11
nc	2
nop	1
dl	0
loc	17
ccs	8
cts	11
cp	0.7272
crap	4.3244
rs	9.9
c	3
b	0
f	0

<?php

declare(strict_types=1);

namespace PhpCfdi\Finkok\Services\Stamping;

use PhpCfdi\Finkok\Definitions\Services;
use PhpCfdi\Finkok\FinkokSettings;

class StampService
{
    /** @var FinkokSettings */
    private $settings;

    public function __construct(FinkokSettings $settings)
    {
        $this->settings = $settings;
    }

    public function settings(): FinkokSettings
    {
        return $this->settings;
    }

    public function stamp(StampingCommand $command): StampingResult
    {
        $soapCaller = $this->settings()->createCallerForService(Services::stamping());
        // Finkok, repeat to fix bad webservice behavior of remote stamp method
        // This will not be fixed according to Finkok
        do {
            $rawResponse = $soapCaller->call('stamp', [
                'xml' => $command->xml(),
            ]);
            $result = new StampingResult('stampResult', $rawResponse);
            if (null !== $result->alerts()->findByErrorCode('307') && '' === $result->uuid()) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                usleep(200000); // 0.2 seconds
                continue;
            }
            break;
        } while (true);
        return $result;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpCfdi\Finkok\Services\Stamping;
6
7		use PhpCfdi\Finkok\Definitions\Services;
8		use PhpCfdi\Finkok\FinkokSettings;
9
10		class StampService
11		{
12		/** @var FinkokSettings */
13		private $settings;
14
15	3	public function __construct(FinkokSettings $settings)
16		{
17	3	$this->settings = $settings;
18	3	}
19
20	1	public function settings(): FinkokSettings
21		{
22	1	return $this->settings;
23		}
24
25	1	public function stamp(StampingCommand $command): StampingResult
26		{
27	1	$soapCaller = $this->settings()->createCallerForService(Services::stamping());
28		// Finkok, repeat to fix bad webservice behavior of remote stamp method
29		// This will not be fixed according to Finkok
30		do {
31	1	$rawResponse = $soapCaller->call('stamp', [
32	1	'xml' => $command->xml(),
33		]);
34	1	$result = new StampingResult('stampResult', $rawResponse);
35	1	if (null !== $result->alerts()->findByErrorCode('307') && '' === $result->uuid()) {
		0 ignored issues – show Bug introduced 2019-09-04 22:23 UTC by Report Bug Copy Issue Report Are you sure the usage of `$result->alerts()->findByErrorCode('307')` targeting `PhpCfdi\Finkok\Services\...erts::findByErrorCode()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
36		usleep(200000); // 0.2 seconds
37		continue;
38		}
39	1	break;
40		} while (true);
41	1	return $result;
42		}
43		}
44

phpcfdi / finkok

Pull Request — master (#8)

StampService::stamp() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like