PhpCfdi\Finkok\Services\Registration\Customers

Complexity

Total Complexity

6

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	findByRfc()	0	9	3
A	createItemFromStdClass()	0	3	1
A	getByRfc()	0	7	2

<?php

declare(strict_types=1);

namespace PhpCfdi\Finkok\Services\Registration;

use LogicException;
use PhpCfdi\Finkok\Services\AbstractCollection;
use stdClass;

class Customers extends AbstractCollection
{
    protected function createItemFromStdClass(stdClass $content): object
    {
        return new Customer($content);
    }

    public function getByRfc(string $rfc): Customer
    {
        $customer = $this->findByRfc($rfc);

Are you sure the assignment to $customer is correct as $this->findByRfc($rfc) targeting PhpCfdi\Finkok\Services\Registration\Customers::findByRfc() seems to always return null.

        if (null === $customer) {

The condition null === $customer is always true.

            throw new LogicException(sprintf('There is no customer with RFC %s', $rfc));
        }
        return $customer;
    }

    public function findByRfc(string $rfc): ?Customer
    {
        /** @var Customer $customer */
        foreach ($this->collection as $customer) {
            if ($rfc === $customer->rfc()) {
                return $customer;
            }
        }
        return null;
    }
}