Customer::__construct() - Code Metrics - Inspection of "Add support for zipcodes on finkok datetime servic..." - phpcfdi/finkok - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

by Carlos C

created 2019-11-03 00:40 UTC

Customer::__construct() A

↳ Parent: Customer

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	10
ccs	7
cts	7
cp	1
crap	3
rs	10

<?php

declare(strict_types=1);

namespace PhpCfdi\Finkok\Services\Registration;

use stdClass;

class Customer
{
    /** @var stdClass */
    private $data;

    /** @var CustomerStatus */
    private $status;

    /** @var CustomerType */
    private $type;

    public function __construct(stdClass $raw)
    {
        $this->data = $raw;
        $rawStatus = strval($this->get('status'));
        if (in_array($rawStatus, CustomerStatus::toArray())) {
            $this->status = new CustomerStatus($rawStatus);
        } else {
            $this->status = CustomerStatus::suspended();
        }
        $this->type = (-1 === $this->credit()) ? CustomerType::ondemand() : CustomerType::prepaid();
    }

    private function get(string $keyword): string
    {
        return strval($this->data->{$keyword} ?? '');
    }

    public function status(): CustomerStatus
    {
        return $this->status;
    }

    public function counter(): int
    {
        return intval($this->get('counter'));
    }

    public function rfc(): string
    {
        return $this->get('taxpayer_id');
    }

    public function credit(): int
    {
        return intval($this->get('credit'));
    }

    public function customerType(): CustomerType
    {
        return $this->type;
    }

    public function values(): array
    {
        return (array) $this->data;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpCfdi\Finkok\Services\Registration;
6
7		use stdClass;
8
9		class Customer
10		{
11		/** @var stdClass */
12		private $data;
13
14		/** @var CustomerStatus */
15		private $status;
16
17		/** @var CustomerType */
18		private $type;
19
20	9	public function __construct(stdClass $raw)
21		{
22	9	$this->data = $raw;
23	9	$rawStatus = strval($this->get('status'));
24	9	if (in_array($rawStatus, CustomerStatus::toArray())) {
25	7	$this->status = new CustomerStatus($rawStatus);
26		} else {
27	2	$this->status = CustomerStatus::suspended();
28		}
29	9	$this->type = (-1 === $this->credit()) ? CustomerType::ondemand() : CustomerType::prepaid();
30	9	}
31
32	9	private function get(string $keyword): string
33		{
34	9	return strval($this->data->{$keyword} ?? '');
35		}
36
37	2	public function status(): CustomerStatus
38		{
39	2	return $this->status;
40		}
41
42	1	public function counter(): int
43		{
44	1	return intval($this->get('counter'));
45		}
46
47	4	public function rfc(): string
48		{
49	4	return $this->get('taxpayer_id');
50		}
51
52	9	public function credit(): int
53		{
54	9	return intval($this->get('credit'));
55		}
56
57	1	public function customerType(): CustomerType
58		{
59	1	return $this->type;
60		}
61
62	2	public function values(): array
63		{
64	2	return (array) $this->data;
65		}
66		}
67

phpcfdi / finkok

Pull Request — master (#11)

Customer::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like