ObtainCustomersService::obtainAll() - Code Metrics - Inspection of "Merge pull request #39 from eclipxe13/development" - phpcfdi/finkok - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( b480f2...a8d709 )

by Carlos C

created 2023-01-04 00:20 UTC

ObtainCustomersService::obtainAll() A

↳ Parent: ObtainCustomersService

Complexity

Conditions	2
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	9
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	13
ccs	9
cts	9
cp	1
crap	2
rs	9.9666

<?php

declare(strict_types=1);

namespace PhpCfdi\Finkok\Services\Registration;

use PhpCfdi\Finkok\Definitions\Services;
use PhpCfdi\Finkok\FinkokSettings;

class ObtainCustomersService
{
    /** @var FinkokSettings */
    private $settings;

    public function __construct(FinkokSettings $settings)
    {
        $this->settings = $settings;
    }

    public function settings(): FinkokSettings
    {
        return $this->settings;
    }

    public function obtainAll(): Customers
    {
        $page = 0;
        $result = new Customers([]);

        do {
            $page = $page + 1;
            $command = new ObtainCustomersCommand($page);
            $current = $this->obtainPage($command);
            $result = $result->merge($current->customers());
        } while ($current->pagesInformation()->hasMorePages());

        return $result;
    }

    public function obtainPage(ObtainCustomersCommand $command): ObtainCustomersResult
    {
        $soapCaller = $this->settings()->createCallerForService(
            Services::registration(),
            'username',
            'password'
        );
        $rawResponse = $soapCaller->call('customers', [
            'page' => $command->page(),
        ]);
        return new ObtainCustomersResult($rawResponse);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpCfdi\Finkok\Services\Registration;
6
7		use PhpCfdi\Finkok\Definitions\Services;
8		use PhpCfdi\Finkok\FinkokSettings;
9
10		class ObtainCustomersService
11		{
12		/** @var FinkokSettings */
13		private $settings;
14
15	4	public function __construct(FinkokSettings $settings)
16		{
17	4	$this->settings = $settings;
18		}
19
20	3	public function settings(): FinkokSettings
21		{
22	3	return $this->settings;
23		}
24
25	1	public function obtainAll(): Customers
26		{
27	1	$page = 0;
28	1	$result = new Customers([]);
29
30		do {
31	1	$page = $page + 1;
32	1	$command = new ObtainCustomersCommand($page);
33	1	$current = $this->obtainPage($command);
34	1	$result = $result->merge($current->customers());
35	1	} while ($current->pagesInformation()->hasMorePages());
36
37	1	return $result;
38		}
39
40	3	public function obtainPage(ObtainCustomersCommand $command): ObtainCustomersResult
41		{
42	3	$soapCaller = $this->settings()->createCallerForService(
43	3	Services::registration(),
44	3	'username',
45	3	'password'
46	3	);
47	3	$rawResponse = $soapCaller->call('customers', [
48	3	'page' => $command->page(),
49	3	]);
50	3	return new ObtainCustomersResult($rawResponse);
51		}
52		}
53

phpcfdi / finkok

Push — main ( b480f2...a8d709 )

ObtainCustomersService::obtainAll() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like