PhpCfdi\CfdiToPdf\Utils\ShellExec

Complexity

Total Complexity

7

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

92.31%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	command()	0	4	1
A	output()	0	4	1
A	lastLine()	0	4	1
A	exitStatus()	0	4	1
A	exec()	0	10	1
A	run()	0	6	1

<?php

declare(strict_types=1);

namespace PhpCfdi\CfdiToPdf\Utils;

class ShellExec
{
    /** @var string */
    private $command;

    /** @var string[] */
    private $output;

    /** @var string */
    private $lastLine;

    /** @var int */
    private $exitStatus;

    /**
     * ShellExec constructor.
     * @param string $command
     * @param string[] $output
     * @param int $exitStatus
     * @param string $lastLine
     */
    public function __construct(string $command, array $output = [], int $exitStatus = -1, string $lastLine = '')
    {
        $this->command = $command;
        $this->output = $output;
        $this->exitStatus = $exitStatus;
        $this->lastLine = $lastLine;
    }

    public function command(): string
    {
        return $this->command;
    }

    public function output(): array
    {
        return $this->output;
    }

    public function lastLine(): string
    {
        return $this->lastLine;
    }

    public function exitStatus(): int
    {
        return $this->exitStatus;
    }

    public function exec()
    {
        $output = [];
        $exitStatus = -1;
        $lastline = exec($this->command(), $output, $exitStatus);

        $this->output = $output;

It seems like $output can be null. However, the property $output is declared as array. Maybe change the type of the property to array|null or add a type check?

        $this->exitStatus = $exitStatus;
        $this->lastLine = $lastline;
    }

    public static function run(string $command): self
    {
        $shellExec = new self($command);
        $shellExec->exec();
        return $shellExec;
    }
}