View GitHub Repository phpbb-website

Schedule Inspection
Subscribe
Completed
Pull Request — master (#93)
by Marc
01:59
created

VigLinkControllerTest::testVigLinkUrl()   A

↳ Parent: VigLinkControllerTest

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 7
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 0
1 
<?php
2 
/**
3 
 *
4 
 * @copyright (c) 2016 phpBB Group
5 
 * @license http://opensource.org/licenses/gpl-3.0.php GNU General Public License v3
6 
 * @author MichaelC
7 
 *
8 
 */
9 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
namespace AppBundle\Tests\Controller;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
use AppBundle\Tests\Controller;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
class VigLinkControllerTest extends BootstrapTestSuite

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
	public function testVigLinkUrl()

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
	{

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
		$objs = $this->setupTest('/viglink/convert?domain=foo.com&siteid=167a0418dd8ce3bf0ef00dfb6195f038&uuid=77950694654327856e6871014d69ad35&key=e4fd14f5d7f2bb6d80b8f8da1354718c');

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
		$crawler = $objs['crawler'];

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
$crawler is not used, you could remove the assignment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for variable assignements that are either overwritten by other
assignments or where the variable is not used subsequently.


$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}





Both the $myVar assignment in line 1 and the $higher assignment in line 2
are dead. The first because $myVar is never used and the second because
$higher is always overwritten for every possible time line.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
		$this->assertTrue($this->client->getResponse()->isSuccessful(), 'Response is a sucessful one');

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
	}

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    24