phpbb\ideas\controller\list_controller::ideas_list()

Complexity

Conditions	15
Paths	33

Size

Total Lines	94
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes	13
Bugs	0	Features	0

<?php
	public function ideas_list($sort)
	{
		if (!$this->is_available())
		{
			throw new http_exception(404, 'IDEAS_NOT_AVAILABLE');
		}

		// Overwrite the $sort parameter if the url contains a sort query.
		// This is needed with the sort by options form at the footer of the list.
		$sort = $this->request->is_set('sort') ? $this->request->variable('sort', ideas::SORT_NEW) : $sort;

		// Get additional query values the url may contain
		$sort_direction = $this->request->variable('sd', 'd');
		$status = $this->request->variable('status', 0);
		$start = $this->request->variable('start', 0);

		// Store original query params for use in breadcrumbs & pagination
		$u_sort = $sort;
		$u_status = $status;
		$u_sort_direction = $sort_direction;

		// convert the sort direction to ASC or DESC
		$sort_direction = ($sort_direction === 'd') ? 'DESC' : 'ASC';

		// If sort by "new" we really use date
		if ($sort === ideas::SORT_NEW)
		{
			$sort = ideas::SORT_DATE;
		}

		// Set the name for displaying in the template
		$status_name = 'LIST_' . strtoupper($status > 0 ? array_search($status, ideas::$statuses) : $sort);

It seems like $status > 0 ? array_search($status, phpbb\ideas\factory\ideas::statuses) : $sort can also be of type false; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

		$status_name = $this->language->is_set($status_name) ? $this->language->lang($status_name) : '';

		// For special case where we want to request ALL ideas,
		// including the statuses normally hidden from lists.
		if ($status === -1)
		{
			$status = ideas::$statuses;
			$status_name = $status_name ?: $this->language->lang('ALL_IDEAS');
		}

		// Generate ideas
		$ideas = $this->ideas->get_ideas($this->config['posts_per_page'], $sort, $sort_direction, $status, $start);
		$this->assign_template_block_vars('ideas', $ideas);

		// Build list page template output
		$this->template->assign_vars(array(
			'U_LIST_ACTION'		=> $this->helper->route('phpbb_ideas_list_controller'),
			'U_POST_ACTION'		=> $this->helper->route('phpbb_ideas_post_controller'),
			'IDEAS_COUNT'       => $this->ideas->get_idea_count(),
			'STATUS_NAME'       => $status_name ?: $this->language->lang('OPEN_IDEAS'),
			'STATUS_ARY'		=> ideas::$statuses,
			'STATUS'			=> $u_status,
			'SORT_ARY'			=> array(ideas::SORT_AUTHOR, ideas::SORT_DATE, ideas::SORT_SCORE, ideas::SORT_TITLE, ideas::SORT_TOP, ideas::SORT_VOTES),
			'SORT'				=> $sort,
			'SORT_DIRECTION'	=> $sort_direction,
			'U_MCP' 			=> ($this->auth->acl_get('m_', $this->config['ideas_forum_id'])) ? append_sid("{$this->root_path}mcp.{$this->php_ext}", "f={$this->config['ideas_forum_id']}&i=main&mode=forum_view", true, $this->user->session_id) : '',

The function append_sid was not found. Maybe you did not declare it correctly or list all dependencies?

		));

		// Recreate the url parameters for the current list
		$params = array(
			'sort'		=> $u_sort ?: null,
			'status'	=> $u_status ?: null,
			'sd'		=> $u_sort_direction ?: null,
		);

		// Assign breadcrumb template vars
		$this->template->assign_block_vars_array('navlinks', array(
			array(
				'U_VIEW_FORUM'	=> $this->helper->route('phpbb_ideas_index_controller'),
				'FORUM_NAME'	=> $this->language->lang('IDEAS'),
			),
			array(
				'U_VIEW_FORUM'	=> $this->helper->route('phpbb_ideas_list_controller', $params),
				'FORUM_NAME'	=> $status_name ?: $this->language->lang('OPEN_IDEAS'),
			),
		));

		// Generate template pagination
		$this->pagination->generate_template_pagination(
			$this->helper->route('phpbb_ideas_list_controller', $params),
			'pagination',
			'start',
			$this->ideas->get_idea_count(),
			$this->config['posts_per_page'],
			$start
		);

		// Display common ideas template vars
		$this->display_common_vars();

		return $this->helper->render('list_body.html', $this->language->lang('IDEA_LIST'));
	}