phpbb-extensions / viglink

ext.php

<?php
/**
 *
 * VigLink extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2014 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\viglink;

/**
 * Extension class for custom enable/disable/purge actions
 */
class ext extends \phpbb\extension\base
{
	/**
	 * Check whether the extension can be enabled.
	 * The current phpBB version should meet or exceed
	 * the minimum version required by this extension:
	 *
	 * Requires phpBB 3.2.0-b1 or greater
	 *
	 * @return bool
	 */
	public function is_enableable()
	{
		return phpbb_version_compare(PHPBB_VERSION, '3.2.0-b1', '>=');

The expression return phpbb_version_compare(phpbb\viglink\PHPBB_VERSION, '3.2.0-b1', '>=') also could return the type integer which is incompatible with the documented return type boolean.

	}

	/**
	 * Check phpBB's VigLink switches and set them during install
	 *
	 * @param	mixed	$old_state	The return value of the previous call
	 *								of this method, or false on the first call
	 *
	 * @return	mixed				Returns false after last step, otherwise
	 *								temporary state which is passed as an
	 *								argument to the next step
	 */
	public function enable_step($old_state)
	{
		if ($old_state === false)
		{
			$viglink_helper = new \phpbb\viglink\acp\viglink_helper(
				$this->container->get('cache.driver'),

It seems like $this->container->get('cache.driver') can also be of type null; however, parameter $cache of phpbb\viglink\acp\viglink_helper::__construct() does only seem to accept phpbb\cache\driver\driver_interface, maybe add an additional type check?

				$this->container->get('config'),

It seems like $this->container->get('config') can also be of type null; however, parameter $config of phpbb\viglink\acp\viglink_helper::__construct() does only seem to accept phpbb\config\config, maybe add an additional type check?

				$this->container->get('file_downloader'),

It seems like $this->container->get('file_downloader') can also be of type null; however, parameter $file_downloader of phpbb\viglink\acp\viglink_helper::__construct() does only seem to accept phpbb\file_downloader, maybe add an additional type check?

				$this->container->get('language'),

It seems like $this->container->get('language') can also be of type null; however, parameter $language of phpbb\viglink\acp\viglink_helper::__construct() does only seem to accept phpbb\language\language, maybe add an additional type check?

				$this->container->get('log'),

It seems like $this->container->get('log') can also be of type null; however, parameter $log of phpbb\viglink\acp\viglink_helper::__construct() does only seem to accept phpbb\log\log, maybe add an additional type check?

				$this->container->get('user')

It seems like $this->container->get('user') can also be of type null; however, parameter $user of phpbb\viglink\acp\viglink_helper::__construct() does only seem to accept phpbb\user, maybe add an additional type check?

			);

			try
			{
				$viglink_helper->set_viglink_services();
			}
			catch (\RuntimeException $e)
			{
				$viglink_helper->log_viglink_error($e->getMessage());
			}

			return 'viglink';
		}

		return parent::enable_step($old_state);
	}
}