m6_hide_for_group::update_data() - Code Metrics - Inspection of "Hide advertisement for specific group" - phpbb-extensions/ad-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Jakub

created 2017-06-12 16:27 UTC

m6_hide_for_group::update_data() A

↳ Parent: m6_hide_for_group

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	0

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\admanagement\migrations\v10x;

class m6_hide_for_group extends \phpbb\db\migration\migration
{
	/**
	* {@inheritDoc}
	*/
	public function effectively_installed()
	{
		$text_config = new \phpbb\config\db_text($this->db, $this->table_prefix . 'config_text');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		return $config_text->get('phpbb_admanagement_hide_groups') !== null;

	}

	/**
	* {@inheritDoc}
	*/
	static public function depends_on()

	{
		return array('\phpbb\admanagement\migrations\v10x\m5_end_date');
	}

	/**
	* Add the ACP settings module
	*
	* @return array Array of data update instructions
	*/
	public function update_data()

	{
		return array(
			array('config_text.add', array('phpbb_admanagement_hide_groups', '[]')),

			array('module.add', array(
				'acp',
				'ACP_ADMANAGEMENT_TITLE',
				array(
					'module_basename'	=> '\phpbb\admanagement\acp\main_module',
					'modes'				=> array('settings'),
				),
			)),
		);
	}
}


1		<?php
2		/**
3		*
4		* Advertisement management. An extension for the phpBB Forum Software package.
5		*
6		* @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7		* @license GNU General Public License, version 2 (GPL-2.0)
8		*
9		*/
10
11		namespace phpbb\admanagement\migrations\v10x;
12
13		class m6_hide_for_group extends \phpbb\db\migration\migration
14		{
15		/**
16		* {@inheritDoc}
17		*/
18		public function effectively_installed()
19		{
20		$text_config = new \phpbb\config\db_text($this->db, $this->table_prefix . 'config_text');
		0 ignored issues – show Unused Code introduced 2017-06-12 16:35 UTC by Report Bug Copy Issue Report `$text_config` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
21
22		return $config_text->get('phpbb_admanagement_hide_groups') !== null;
		0 ignored issues – show Bug introduced 2017-06-12 15:17 UTC by Report Bug Copy Issue Report The variable `$config_text` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
23		}
24
25		/**
26		* {@inheritDoc}
27		*/
28		static public function depends_on()
		1 ignored issue – show Coding Style introduced 2017-06-05 20:49 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
29		{
30		return array('\phpbb\admanagement\migrations\v10x\m5_end_date');
31		}
32
33		/**
34		* Add the ACP settings module
35		*
36		* @return array Array of data update instructions
37		*/
38	View Code Duplication	public function update_data()
		1 ignored issue – show Duplication introduced 2017-06-10 19:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		return array(
41		array('config_text.add', array('phpbb_admanagement_hide_groups', '[]')),
42
43		array('module.add', array(
44		'acp',
45		'ACP_ADMANAGEMENT_TITLE',
46		array(
47		'module_basename' => '\phpbb\admanagement\acp\main_module',
48		'modes' => array('settings'),
49		),
50		)),
51		);
52		}
53		}
54

phpbb-extensions / ad-management

Pull Request — master (#16)

m6_hide_for_group::update_data() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like