Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class m3_add_start_date extends \phpbb\db\migration\migration |
|
1 ignored issue
–
show
|
|||
14 | { |
||
15 | /** |
||
16 | * {@inheritDoc} |
||
17 | */ |
||
18 | public function effectively_installed() |
||
22 | |||
23 | /** |
||
24 | * {@inheritDoc} |
||
25 | */ |
||
26 | public static function depends_on() |
||
33 | |||
34 | /** |
||
35 | * Add the start date option to ads table |
||
36 | * |
||
37 | * @return array Array of table schema |
||
38 | * @access public |
||
39 | */ |
||
40 | public function update_schema() |
||
50 | |||
51 | /** |
||
52 | * Drop the start date option from ads table |
||
53 | * |
||
54 | * @return array Array of table schema |
||
55 | * @access public |
||
56 | */ |
||
57 | public function revert_schema() |
||
67 | } |
||
68 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.