phpbb\admanagement\migrations\v10x\m6_hide_for_group

Complexity

Total Complexity

3

Size/Duplication

Total Lines	39
Duplicated Lines	38.46 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	effectively_installed()	0	4	1
A	depends_on()	0	4	1
A	update_data()	15	15	1

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\admanagement\migrations\v10x;

class m6_hide_for_group extends \phpbb\db\migration\migration
{
	/**
	* {@inheritDoc}
	*/
	public function effectively_installed()
	{
		return $config_text->get('phpbb_admanagement_hide_groups') !== null;

The variable $config_text does not exist. Did you forget to declare it?

	}

	/**
	* {@inheritDoc}
	*/
	static public function depends_on()

As per PSR2, the static declaration should come after the visibility declaration.

	{
		return array('\phpbb\admanagement\migrations\v10x\m5_end_date');
	}

	/**
	* Add the ACP settings module
	*
	* @return array Array of data update instructions
	*/
	public function update_data()

This method seems to be duplicated in your project.

	{
		return array(
			array('config_text.add', array('phpbb_admanagement_hide_groups', '[]')),

			array('module.add', array(
				'acp',
				'ACP_ADMANAGEMENT_TITLE',
				array(
					'module_basename'	=> '\phpbb\admanagement\acp\main_module',
					'modes'				=> array('settings'),
				),
			)),
		);
	}
}