Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | View Code Duplication | class m13_hide_on_noncontent_pages extends \phpbb\db\migration\migration |
|
|
|
|||
| 14 | { |
||
| 15 | /** |
||
| 16 | * {@inheritDoc} |
||
| 17 | */ |
||
| 18 | public function effectively_installed() |
||
| 22 | |||
| 23 | /** |
||
| 24 | * {@inheritDoc} |
||
| 25 | */ |
||
| 26 | public static function depends_on() |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Add phpbb_ads_hide_on_noncontent config |
||
| 33 | * |
||
| 34 | * @return array Array of data update instructions |
||
| 35 | */ |
||
| 36 | public function update_data() |
||
| 42 | } |
||
| 43 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.