View GitHub Repository ad-management

Schedule Inspection
Subscribe
Completed
Pull Request — master (#69)
by Jakub
11:45 queued 02:37
created

script_without_async::run()   A

↳ Parent: script_without_async

Complexity

Conditions 4
Paths 3

Size

Total Lines 18
Code Lines 8

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 12
CRAP Score 4

Importance

Changes 0
Metric Value
dl 0
loc 18
ccs 12
cts 12
cp 1
rs 9.2
c 0
b 0
f 0
cc 4
eloc 8
nc 3
nop 1
crap 4
1 
<?php
2 
/**
3 
 *
4 
 * Advertisement management. An extension for the phpBB Forum Software package.
5 
 *
6 
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7 
 * @license GNU General Public License, version 2 (GPL-2.0)
8 
 *
9 
 */
10 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
namespace phpbb\ads\analyser\test;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
class script_without_async implements test_interface

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
	/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
	 * {@inheritDoc}

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
	 *

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
	 * Synchronously loaded scripts test.

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
	 * This test looks for scripts that aren't using `async` attribute

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
	 * to load itself asynchronously. Such scripts slow down page rendering

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
	 * time and should be made asynchronous.

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
	 */

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                             13                         
                
                
                
	public function run($ad_code)

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
	{

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                             13                         
                
                
                
		if (preg_match_all('/&lt;script(.*)src(.*)&gt;/U', $ad_code, $matches))

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                             13                         
                
                
                
		{

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                             8                         
                
                
                
			foreach ($matches[1] as $match)

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
			{

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                             8                         
                
                
                
				if (!preg_match('/ async/', $match))

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                             8                         
                
                
                
				{

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
					return array(

            


            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                             5                         
                
                
                
						'severity'	=> 'notice',

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                             5                         
                
                
                
						'message'	=> 'SCRIPT_WITHOUT_ASYNC',

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                             5                         
                
                
                
					);

            


            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
				}

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                             4                         
                
                
                
			}

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                             3                         
                
                
                
		}

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    39
                

                                    
                             8                         
                
                
                
		return false;

            


            
                                                        
            
                                    
            
            

                
                    40
                

                                    
                                                    
                
                
                
	}

            


            
                                                        
            
                                    
            
            

                
                    41
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    42