phpbb\admanagement\migrations\v10x\m2_acp_module

Complexity

Total Complexity

3

Size/Duplication

Total Lines	50
Duplicated Lines	24 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	depends_on()	0	4	1
A	update_data()	0	18	1
A	effectively_installed()	12	12	1

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\admanagement\migrations\v10x;

class m2_acp_module extends \phpbb\db\migration\migration
{
	/**
	* {@inheritDoc}
	*/
	public function effectively_installed()

This method seems to be duplicated in your project.

	{
		$sql = 'SELECT module_id
			FROM ' . $this->table_prefix . "modules
			WHERE module_class = 'acp'
				AND module_langname = 'ACP_ADMANAGEMENT_TITLE'";
		$result = $this->db->sql_query($sql);
		$module_id = (int) $this->db->sql_fetchfield('module_id');
		$this->db->sql_freeresult($result);

		return $module_id;
	}

	/**
	* {@inheritDoc}
	*/
	static public function depends_on()

As per PSR2, the static declaration should come after the visibility declaration.

	{
		return array('\phpbb\admanagement\migrations\v10x\m1_initial_schema');
	}

	/**
	* Add the ACP module
	*
	* @return array Array of data update instructions
	*/
	public function update_data()
	{
		return array(
			array('module.add', array(
				'acp',
				'ACP_CAT_DOT_MODS',
				'ACP_ADMANAGEMENT_TITLE'
			)),
			array('module.add', array(
				'acp',
				'ACP_ADMANAGEMENT_TITLE',
				array(
					'module_basename'	=> '\phpbb\admanagement\acp\main_module',
					'modes'				=> array('manage'),
				),
			)),
		);
	}
}