main_module::main() - Code Metrics - Inspection of "Create basic extension skeleton" - phpbb-extensions/ad-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Jakub

created 2017-05-19 08:10 UTC

main_module::main() B

↳ Parent: main_module

Complexity

Conditions	3
Paths	3

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	26
rs	8.8571
cc	3
eloc	14
nc	3
nop	2

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\admanagement\acp;

/**
 * Advertisement management ACP module.
 */
class main_module
{
	public $page_title;
	public $tpl_name;
	public $u_action;

	public function main($id, $mode)

	{
		global $config, $request, $template, $user;
function myFunction($a, $b) {
    // Do something
}

		$user->add_lang_ext('phpbb/admanagement', 'common');
		$this->tpl_name = 'acp_demo_body';
		$this->page_title = $user->lang('ACP_DEMO_TITLE');
		add_form_key('acme/demo');

		if ($request->is_set_post('submit'))
		{
			if (!check_form_key('acme/demo'))
			{
				trigger_error('FORM_INVALID', E_USER_WARNING);
			}

			$config->set('acme_demo_goodbye', $request->variable('acme_demo_goodbye', 0));

			trigger_error($user->lang('ACP_DEMO_SETTING_SAVED') . adm_back_link($this->u_action));
		}

		$template->assign_vars(array(
			'U_ACTION'				=> $this->u_action,
			'ACME_DEMO_GOODBYE'		=> $config['acme_demo_goodbye'],
		));
	}
}


1			<?php
2			/**
3			*
4			* Advertisement management. An extension for the phpBB Forum Software package.
5			*
6			* @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7			* @license GNU General Public License, version 2 (GPL-2.0)
8			*
9			*/
10
11			namespace phpbb\admanagement\acp;
12
13			/**
14			* Advertisement management ACP module.
15			*/
16			class main_module
17			{
18			public $page_title;
19			public $tpl_name;
20			public $u_action;
21
22			public function main($id, $mode)
			0 ignored issues – show Unused Code introduced 2017-05-19 07:49 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-19 07:49 UTC by Report Bug Copy Issue Report The parameter `$mode` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
23			{
24			global $config, $request, $template, $user;
			0 ignored issues – show Compatibility Best Practice introduced 2017-05-19 07:49 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
25
26			$user->add_lang_ext('phpbb/admanagement', 'common');
27			$this->tpl_name = 'acp_demo_body';
28			$this->page_title = $user->lang('ACP_DEMO_TITLE');
29			add_form_key('acme/demo');
30
31			if ($request->is_set_post('submit'))
32			{
33			if (!check_form_key('acme/demo'))
34			{
35			trigger_error('FORM_INVALID', E_USER_WARNING);
36			}
37
38			$config->set('acme_demo_goodbye', $request->variable('acme_demo_goodbye', 0));
39
40			trigger_error($user->lang('ACP_DEMO_SETTING_SAVED') . adm_back_link($this->u_action));
41			}
42
43			$template->assign_vars(array(
44			'U_ACTION' => $this->u_action,
45			'ACME_DEMO_GOODBYE' => $config['acme_demo_goodbye'],
46			));
47			}
48			}
49

phpbb-extensions / ad-management

Pull Request — master (#1)

main_module::main() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like