manager::delete_ad() - Code Metrics - Inspection of "Template locations" - phpbb-extensions/ad-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Jakub

created 2017-06-05 07:48 UTC

manager::delete_ad() A

↳ Parent: manager

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	0
cts	5
cp	0
rs	9.4285
cc	1
eloc	5
nc	1
nop	1
crap	2

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\admanagement\ad;

class manager
{
	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var string */
	protected $ads_table;

	/** @var string */
	protected $ad_locations_table;

	/**
	* Constructor
	*
	* @param	\phpbb\db\driver\driver_interface	$db					DB driver interface
	* @param	string								$ads_table			Ads table
	* @param	string								$ad_locations_table	Ad locations table
	*/
	public function __construct(\phpbb\db\driver\driver_interface $db, $ads_table, $ad_locations_table)
	{
		$this->db = $db;
		$this->ads_table = $ads_table;
		$this->ad_locations_table = $ad_locations_table;
	}

	/**
	* Get specific ad
	*
	* @param	int		$ad_id	Advertisement ID
	* @return	array	Advertisement data
	*/
	public function get_ad($ad_id)

	{
		$sql = 'SELECT *
			FROM ' . $this->ads_table . '
			WHERE ad_id = ' . (int) $ad_id;
		$result = $this->db->sql_query($sql);
		$data = $this->db->sql_fetchrow($result);
		$this->db->sql_freeresult($result);

		return $data;
	}

	/**
	* Get one ad per every location
	*
	* @param	array	$ad_locations	List of ad locations to fetch ads for
	* @return	array	List of ad codes for each location
	*/
	public function get_ads($ad_locations)
	{
		$sql = 'SELECT location_id, ad_code
			FROM (
				SELECT al.location_id, a.ad_code
				FROM ' . $this->ad_locations_table . ' al
				LEFT JOIN ' . $this->ads_table . ' a
					ON (al.ad_id = a.ad_id)
				WHERE a.ad_enabled = 1
					AND ' . $this->db->sql_in_set('al.location_id', $ad_locations) . '
				ORDER BY ' . $this->sql_random() . '
			) z
			ORDER BY z.location_id';
		$result = $this->db->sql_query($sql);
		$data = $this->db->sql_fetchrowset($result);
		$this->db->sql_freeresult($result);

		return $data;
	}

	/**
	* Get all advertisements
	*
	* @return	array	List of all ads
	*/
	public function get_all_ads()

	{
		$sql = 'SELECT ad_id, ad_name, ad_enabled
			FROM ' . $this->ads_table;
		$result = $this->db->sql_query($sql);
		$data = $this->db->sql_fetchrowset($result);
		$this->db->sql_freeresult($result);

		return $data;
	}

	/**
	* Insert new advertisement to the database
	*
	* @param	array	$data	New ad data
	* @return	int		New advertisement ID
	*/
	public function insert_ad($data)

	{
		$data = $this->intersect_ad_data($data);

		$sql = 'INSERT INTO ' . $this->ads_table . ' ' . $this->db->sql_build_array('INSERT', $data);
		$this->db->sql_query($sql);

		return $this->db->sql_nextid();
	}

	/**
	* Update advertisement
	*
	* @param	int		$ad_id	Advertisement ID
	* @param	array	$data	List of data to update in the database
	* @return	int		Number of affected rows. Can be used to determine if any ad has been updated.
	*/
	public function update_ad($ad_id, $data)

	{
		$data = $this->intersect_ad_data($data);

		$sql = 'UPDATE ' . $this->ads_table . '
			SET ' . $this->db->sql_build_array('UPDATE', $data) . '
			WHERE ad_id = ' . (int) $ad_id;
		$this->db->sql_query($sql);

		return $this->db->sql_affectedrows();
	}

	/**
	* Delete advertisement
	*
	* @param	int		$ad_id	Advertisement ID
	* @return	int		Number of affected rows. Can be used to determine if any ad has been deleted.
	*/
	public function delete_ad($ad_id)
	{
		$sql = 'DELETE FROM ' . $this->ads_table . '
			WHERE ad_id = ' . (int) $ad_id;
		$this->db->sql_query($sql);

		return $this->db->sql_affectedrows();
	}

	/**
	* Get all locations for specified advertisement
	*
	* @param	int		$ad_id	Advertisement ID
	* @return	array	List of template locations for specified ad
	*/
	public function get_ad_locations($ad_id)
	{
		$ad_locations = array();

		$sql = 'SELECT location_id
			FROM ' . $this->ad_locations_table . '
			WHERE ad_id = ' . (int) $ad_id;
		$result = $this->db->sql_query($sql);
		while ($row = $this->db->sql_fetchrow($result))
		{
			$ad_locations[] = $row['location_id'];
		}
		$this->db->sql_freeresult($result);

		return $ad_locations;
	}

	/**
	* Insert advertisement locations
	*
	* @param	int		$ad_id			Advertisement ID
	* @param	array	$ad_locations	List of template locations for this ad
	* @return	void
	*/
	public function insert_ad_locations($ad_id, $ad_locations)
	{
		$sql_ary = array();
		foreach ($ad_locations as $ad_location)
		{
			$sql_ary[] = array(
				'ad_id'			=> $ad_id,
				'location_id'	=> $ad_location,
			);
		}
		$this->db->sql_multi_insert($this->ad_locations_table, $sql_ary);
	}

	/**
	* Delete advertisement locations
	*
	* @param	int		$ad_id	Advertisement ID
	* @return	void
	*/
	public function delete_ad_locations($ad_id)
	{
		$sql = 'DELETE FROM ' . $this->ad_locations_table . '
			WHERE ad_id = ' . (int) $ad_id;
		$this->db->sql_query($sql);
	}

	/**
	* Make sure only necessary data make their way to SQL query
	*
	* @param	array	$data	List of data to query the database
	* @return	array	Cleaned data that contain only valid keys
	*/
	protected function intersect_ad_data($data)
	{
		return array_intersect_key($data, array(
			'ad_name'		=> '',
			'ad_note'		=> '',
			'ad_code'		=> '',
			'ad_enabled'	=> '',
		));
	}

	/**
	* Get the random statement for this database layer
	*
	* @return	string	Random statement for current database layer
	*/
	protected function sql_random()
	{
		switch ($this->db->get_sql_layer())
		{
			case 'oracle':
			case 'postgres':
			case 'sqlite':
			case 'sqlite3':
				return 'RANDOM()';

			/* All other cases should use the default

			case 'mssql':
			case 'mssql_odbc':
			case 'mssqlnative':
			case 'mysql':
			case 'mysqli':*/
			default:
				return 'RAND()';
		}
	}
}


1			<?php
2			/**
3			*
4			* Advertisement management. An extension for the phpBB Forum Software package.
5			*
6			* @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7			* @license GNU General Public License, version 2 (GPL-2.0)
8			*
9			*/
10
11			namespace phpbb\admanagement\ad;
12
13			class manager
14			{
15			/** @var \phpbb\db\driver\driver_interface */
16			protected $db;
17
18			/** @var string */
19			protected $ads_table;
20
21			/** @var string */
22			protected $ad_locations_table;
23
24			/**
25			* Constructor
26			*
27			* @param \phpbb\db\driver\driver_interface $db DB driver interface
28			* @param string $ads_table Ads table
29			* @param string $ad_locations_table Ad locations table
30			*/
31	2		public function __construct(\phpbb\db\driver\driver_interface $db, $ads_table, $ad_locations_table)
32			{
33	2		$this->db = $db;
34	2		$this->ads_table = $ads_table;
35	2		$this->ad_locations_table = $ad_locations_table;
36	2		}
37
38			/**
39			* Get specific ad
40			*
41			* @param int $ad_id Advertisement ID
42			* @return array Advertisement data
43			*/
44		View Code Duplication	public function get_ad($ad_id)
			1 ignored issue – show Duplication introduced 2017-05-31 10:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46			$sql = 'SELECT *
47			FROM ' . $this->ads_table . '
48			WHERE ad_id = ' . (int) $ad_id;
49			$result = $this->db->sql_query($sql);
50			$data = $this->db->sql_fetchrow($result);
51			$this->db->sql_freeresult($result);
52
53			return $data;
54			}
55
56			/**
57			* Get one ad per every location
58			*
59			* @param array $ad_locations List of ad locations to fetch ads for
60			* @return array List of ad codes for each location
61			*/
62			public function get_ads($ad_locations)
63			{
64			$sql = 'SELECT location_id, ad_code
65			FROM (
66			SELECT al.location_id, a.ad_code
67			FROM ' . $this->ad_locations_table . ' al
68			LEFT JOIN ' . $this->ads_table . ' a
69			ON (al.ad_id = a.ad_id)
70			WHERE a.ad_enabled = 1
71			AND ' . $this->db->sql_in_set('al.location_id', $ad_locations) . '
72			ORDER BY ' . $this->sql_random() . '
73			) z
74			ORDER BY z.location_id';
75			$result = $this->db->sql_query($sql);
76			$data = $this->db->sql_fetchrowset($result);
77			$this->db->sql_freeresult($result);
78
79			return $data;
80			}
81
82			/**
83			* Get all advertisements
84			*
85			* @return array List of all ads
86			*/
87		View Code Duplication	public function get_all_ads()
			1 ignored issue – show Duplication introduced 2017-05-31 10:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88			{
89			$sql = 'SELECT ad_id, ad_name, ad_enabled
90			FROM ' . $this->ads_table;
91			$result = $this->db->sql_query($sql);
92			$data = $this->db->sql_fetchrowset($result);
93			$this->db->sql_freeresult($result);
94
95			return $data;
96			}
97
98			/**
99			* Insert new advertisement to the database
100			*
101			* @param array $data New ad data
102			* @return int New advertisement ID
103			*/
104		View Code Duplication	public function insert_ad($data)
			1 ignored issue – show Duplication introduced 2017-05-31 10:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105			{
106			$data = $this->intersect_ad_data($data);
107
108			$sql = 'INSERT INTO ' . $this->ads_table . ' ' . $this->db->sql_build_array('INSERT', $data);
109			$this->db->sql_query($sql);
110
111			return $this->db->sql_nextid();
112			}
113
114			/**
115			* Update advertisement
116			*
117			* @param int $ad_id Advertisement ID
118			* @param array $data List of data to update in the database
119			* @return int Number of affected rows. Can be used to determine if any ad has been updated.
120			*/
121		View Code Duplication	public function update_ad($ad_id, $data)
			1 ignored issue – show Duplication introduced 2017-05-31 10:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
122			{
123			$data = $this->intersect_ad_data($data);
124
125			$sql = 'UPDATE ' . $this->ads_table . '
126			SET ' . $this->db->sql_build_array('UPDATE', $data) . '
127			WHERE ad_id = ' . (int) $ad_id;
128			$this->db->sql_query($sql);
129
130			return $this->db->sql_affectedrows();
131			}
132
133			/**
134			* Delete advertisement
135			*
136			* @param int $ad_id Advertisement ID
137			* @return int Number of affected rows. Can be used to determine if any ad has been deleted.
138			*/
139			public function delete_ad($ad_id)
140			{
141			$sql = 'DELETE FROM ' . $this->ads_table . '
142			WHERE ad_id = ' . (int) $ad_id;
143			$this->db->sql_query($sql);
144
145			return $this->db->sql_affectedrows();
146			}
147
148			/**
149			* Get all locations for specified advertisement
150			*
151			* @param int $ad_id Advertisement ID
152			* @return array List of template locations for specified ad
153			*/
154			public function get_ad_locations($ad_id)
155			{
156			$ad_locations = array();
157
158			$sql = 'SELECT location_id
159			FROM ' . $this->ad_locations_table . '
160			WHERE ad_id = ' . (int) $ad_id;
161			$result = $this->db->sql_query($sql);
162			while ($row = $this->db->sql_fetchrow($result))
163			{
164			$ad_locations[] = $row['location_id'];
165			}
166			$this->db->sql_freeresult($result);
167
168			return $ad_locations;
169			}
170
171			/**
172			* Insert advertisement locations
173			*
174			* @param int $ad_id Advertisement ID
175			* @param array $ad_locations List of template locations for this ad
176			* @return void
177			*/
178			public function insert_ad_locations($ad_id, $ad_locations)
179			{
180			$sql_ary = array();
181			foreach ($ad_locations as $ad_location)
182			{
183			$sql_ary[] = array(
184			'ad_id' => $ad_id,
185			'location_id' => $ad_location,
186			);
187			}
188			$this->db->sql_multi_insert($this->ad_locations_table, $sql_ary);
189			}
190
191			/**
192			* Delete advertisement locations
193			*
194			* @param int $ad_id Advertisement ID
195			* @return void
196			*/
197			public function delete_ad_locations($ad_id)
198			{
199			$sql = 'DELETE FROM ' . $this->ad_locations_table . '
200			WHERE ad_id = ' . (int) $ad_id;
201			$this->db->sql_query($sql);
202			}
203
204			/**
205			* Make sure only necessary data make their way to SQL query
206			*
207			* @param array $data List of data to query the database
208			* @return array Cleaned data that contain only valid keys
209			*/
210			protected function intersect_ad_data($data)
211			{
212			return array_intersect_key($data, array(
213			'ad_name' => '',
214			'ad_note' => '',
215			'ad_code' => '',
216			'ad_enabled' => '',
217			));
218			}
219
220			/**
221			* Get the random statement for this database layer
222			*
223			* @return string Random statement for current database layer
224			*/
225			protected function sql_random()
226			{
227			switch ($this->db->get_sql_layer())
228			{
229			case 'oracle':
230			case 'postgres':
231			case 'sqlite':
232			case 'sqlite3':
233			return 'RANDOM()';
234
235			/* All other cases should use the default
			1 ignored issue – show Unused Code Comprehensibility introduced 2017-05-31 10:41 UTC by Report Bug Copy Issue Report `44%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
236			case 'mssql':
237			case 'mssql_odbc':
238			case 'mssqlnative':
239			case 'mysql':
240			case 'mysqli':*/
241			default:
242			return 'RAND()';
243			}
244			}
245			}
246

phpbb-extensions / ad-management

Pull Request — master (#4)

manager::delete_ad() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like