m2_centering_option::effectively_installed() - Code Metrics - Inspection of "Introduce ad centering option" - phpbb-extensions/ad-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#126)

by Jakub

created 2018-06-11 09:49 UTC

m2_centering_option::effectively_installed() A

↳ Parent: m2_centering_option

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\ads\migrations\v20x;

class m2_centering_option extends \phpbb\db\migration\migration

{
	/**
	 * {@inheritDoc}
	 */
	public function effectively_installed()
	{
		return $this->db_tools->sql_column_exists($this->table_prefix . 'ads', 'ad_centering');
	}

	/**
	 * {@inheritDoc}
	 */
	public static function depends_on()
	{
		return array(
			'\phpbb\ads\migrations\v10x\m1_initial_schema',
			'\phpbb\ads\migrations\v10x\m4_indexes',
		);
	}

	/**
	 * Add the centering option to ads table
	 *
	 * @return array Array of table schema
	 * @access public
	 */
	public function update_schema()
	{
		return array(
			'add_columns' => array(
				$this->table_prefix . 'ads' => array(
					'ad_centering' => array('BOOL', 1),
				),
			),
		);
	}

	/**
	 * Drop the centering option from ads table
	 *
	 * @return array Array of table schema
	 * @access public
	 */
	public function revert_schema()
	{
		return array(
			'drop_columns' => array(
				$this->table_prefix . 'ads' => array(
					'ad_centering',
				),
			),
		);
	}
}


1		<?php
2		/**
3		*
4		* Advertisement management. An extension for the phpBB Forum Software package.
5		*
6		* @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7		* @license GNU General Public License, version 2 (GPL-2.0)
8		*
9		*/
10
11		namespace phpbb\ads\migrations\v20x;
12
13	View Code Duplication	class m2_centering_option extends \phpbb\db\migration\migration
		1 ignored issue – show Duplication introduced 2018-06-11 10:01 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		/**
16		* {@inheritDoc}
17		*/
18		public function effectively_installed()
19		{
20		return $this->db_tools->sql_column_exists($this->table_prefix . 'ads', 'ad_centering');
21		}
22
23		/**
24		* {@inheritDoc}
25		*/
26		public static function depends_on()
27		{
28		return array(
29		'\phpbb\ads\migrations\v10x\m1_initial_schema',
30		'\phpbb\ads\migrations\v10x\m4_indexes',
31		);
32		}
33
34		/**
35		* Add the centering option to ads table
36		*
37		* @return array Array of table schema
38		* @access public
39		*/
40		public function update_schema()
41		{
42		return array(
43		'add_columns' => array(
44		$this->table_prefix . 'ads' => array(
45		'ad_centering' => array('BOOL', 1),
46		),
47		),
48		);
49		}
50
51		/**
52		* Drop the centering option from ads table
53		*
54		* @return array Array of table schema
55		* @access public
56		*/
57		public function revert_schema()
58		{
59		return array(
60		'drop_columns' => array(
61		$this->table_prefix . 'ads' => array(
62		'ad_centering',
63		),
64		),
65		);
66		}
67		}
68

phpbb-extensions / ad-management

Pull Request — master (#126)

m2_centering_option::effectively_installed() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like