click_controller::increment_clicks() - Code Metrics - Inspection of "Views & Clicks" - phpbb-extensions/ad-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

by Jakub

created 2017-07-15 20:49 UTC

click_controller::increment_clicks() A

↳ Parent: click_controller

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	9.4285
cc	3
eloc	5
nc	2
nop	1
crap	3

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\ads\controller;

/**
* Front controller
*/
class click_controller
{
	/** @var \phpbb\ads\ad\manager */
	protected $manager;

	/** @var \phpbb\request\request */
	protected $request;

	/**
	 * Constructor
	 *
	 * @param \phpbb\ads\ad\manager    $manager Advertisement manager object
	 * @param \phpbb\request\request   $request	Request object
	 */
	public function __construct(\phpbb\ads\ad\manager $manager, \phpbb\request\request $request)
	{
		$this->manager = $manager;
		$this->request = $request;
	}

	/**
	* Increment clicks for an ad
	*
	* @param	int	$ad_id	Advertisement ID
	* @return	\Symfony\Component\HttpFoundation\JsonResponse	A Symfony JsonResponse object
	*/
	public function increment_clicks($ad_id)
	{
		if ($this->request->is_ajax() && !empty($ad_id))
		{
			$this->manager->increment_ad_clicks($ad_id);

			return new \Symfony\Component\HttpFoundation\JsonResponse();
		}

		throw new \phpbb\exception\http_exception(403, 'NOT_AUTHORISED');
	}
}


1		<?php
2		/**
3		*
4		* Advertisement management. An extension for the phpBB Forum Software package.
5		*
6		* @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7		* @license GNU General Public License, version 2 (GPL-2.0)
8		*
9		*/
10
11		namespace phpbb\ads\controller;
12
13		/**
14		* Front controller
15		*/
16		class click_controller
17		{
18		/** @var \phpbb\ads\ad\manager */
19		protected $manager;
20
21		/** @var \phpbb\request\request */
22		protected $request;
23
24		/**
25		* Constructor
26		*
27		* @param \phpbb\ads\ad\manager $manager Advertisement manager object
28		* @param \phpbb\request\request $request Request object
29		*/
30	3	public function __construct(\phpbb\ads\ad\manager $manager, \phpbb\request\request $request)
31		{
32	3	$this->manager = $manager;
33	3	$this->request = $request;
34	3	}
35
36		/**
37		* Increment clicks for an ad
38		*
39		* @param int $ad_id Advertisement ID
40		* @return \Symfony\Component\HttpFoundation\JsonResponse A Symfony JsonResponse object
41		*/
42	3	public function increment_clicks($ad_id)
43		{
44	3	if ($this->request->is_ajax() && !empty($ad_id))
45	3	{
46	1	$this->manager->increment_ad_clicks($ad_id);
47
48	1	return new \Symfony\Component\HttpFoundation\JsonResponse();
49		}
50
51	2	throw new \phpbb\exception\http_exception(403, 'NOT_AUTHORISED');
52		}
53		}
54

phpbb-extensions / ad-management

Pull Request — master (#43)

click_controller::increment_clicks() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like