m2_acp_module::effectively_installed() - Code Metrics - Inspection of "Merge pull request #4 from senky/template-location..." - phpbb-extensions/ad-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88d06e...79f4e6 )

by Matt

created 2017-06-06 15:32 UTC

m2_acp_module::effectively_installed() A

↳ Parent: m2_acp_module

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes

Metric	Value
dl	12
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php
/**
 *
 * Advertisement management. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace phpbb\admanagement\migrations\v10x;

class m2_acp_module extends \phpbb\db\migration\migration
{
	/**
	* {@inheritDoc}
	*/
	public function effectively_installed()

	{
		$sql = 'SELECT module_id
			FROM ' . $this->table_prefix . "modules
			WHERE module_class = 'acp'
				AND module_langname = 'ACP_ADMANAGEMENT_TITLE'";
		$result = $this->db->sql_query($sql);
		$module_id = (int) $this->db->sql_fetchfield('module_id');
		$this->db->sql_freeresult($result);

		return $module_id;
	}

	/**
	* {@inheritDoc}
	*/
	static public function depends_on()

	{
		return array('\phpbb\admanagement\migrations\v10x\m1_initial_schema');
	}

	/**
	* Add the ACP module
	*
	* @return array Array of data update instructions
	*/
	public function update_data()
	{
		return array(
			array('module.add', array(
				'acp',
				'ACP_CAT_DOT_MODS',
				'ACP_ADMANAGEMENT_TITLE'
			)),
			array('module.add', array(
				'acp',
				'ACP_ADMANAGEMENT_TITLE',
				array(
					'module_basename'	=> '\phpbb\admanagement\acp\main_module',
					'modes'				=> array('manage'),
				),
			)),
		);
	}
}


1		<?php
2		/**
3		*
4		* Advertisement management. An extension for the phpBB Forum Software package.
5		*
6		* @copyright (c) 2017 phpBB Limited <https://www.phpbb.com>
7		* @license GNU General Public License, version 2 (GPL-2.0)
8		*
9		*/
10
11		namespace phpbb\admanagement\migrations\v10x;
12
13		class m2_acp_module extends \phpbb\db\migration\migration
14		{
15		/**
16		* {@inheritDoc}
17		*/
18	View Code Duplication	public function effectively_installed()
		1 ignored issue – show Duplication introduced 2017-05-31 10:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$sql = 'SELECT module_id
21		FROM ' . $this->table_prefix . "modules
22		WHERE module_class = 'acp'
23		AND module_langname = 'ACP_ADMANAGEMENT_TITLE'";
24		$result = $this->db->sql_query($sql);
25		$module_id = (int) $this->db->sql_fetchfield('module_id');
26		$this->db->sql_freeresult($result);
27
28		return $module_id;
29		}
30
31		/**
32		* {@inheritDoc}
33		*/
34		static public function depends_on()
		1 ignored issue – show Coding Style introduced 2017-05-30 20:57 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
35		{
36		return array('\phpbb\admanagement\migrations\v10x\m1_initial_schema');
37		}
38
39		/**
40		* Add the ACP module
41		*
42		* @return array Array of data update instructions
43		*/
44		public function update_data()
45		{
46		return array(
47		array('module.add', array(
48		'acp',
49		'ACP_CAT_DOT_MODS',
50		'ACP_ADMANAGEMENT_TITLE'
51		)),
52		array('module.add', array(
53		'acp',
54		'ACP_ADMANAGEMENT_TITLE',
55		array(
56		'module_basename' => '\phpbb\admanagement\acp\main_module',
57		'modes' => array('manage'),
58		),
59		)),
60		);
61		}
62		}
63

phpbb-extensions / ad-management

Push — master ( 88d06e...79f4e6 )

m2_acp_module::effectively_installed() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like