ClassScanner::getClassNameFromFile() - Code Metrics - Inspection of "Simple class to file" - phpactor/class-to-file - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5db41f...c1280c )

by Daniel

created 2018-01-01 16:44 UTC

ClassScanner::getClassNameFromFile() C

↳ Parent: ClassScanner

Complexity

Conditions	15
Paths	4

Size

Total Lines	52
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
rs	5.9385
c	0
b	0
f	0
cc	15
eloc	28
nc	4
nop	1

How to fix Long Method Complexity

<?php

namespace Phpactor\ClassFileConverter\Adapter\Simple;

/**
 * Return the class name from a file.
 *
 * Based on http://stackoverflow.com/questions/7153000/get-class-name-from-file
 */
class ClassScanner
{
    public function getClassNameFromFile($file)
    {
        $fp = fopen($file, 'r');

        $class = $namespace = $buffer = '';
        $i = 0;

        while (!$class) {
            if (feof($fp)) {
                break;
            }

            // Read entire lines to prevent keyword truncation
            for ($line = 0; $line <= 20; $line++) {
                $buffer .= fgets($fp);
            }
            $tokens = @token_get_all($buffer);

            if (strpos($buffer, '{') === false) {
                continue;
            }

            for (; $i < count($tokens); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                if ($tokens[$i][0] === \T_NAMESPACE) {
                    for ($j = $i + 1; $j < count($tokens); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                        if ($tokens[$j][0] === T_STRING) {
                            $namespace .= '\\' . $tokens[$j][1];
                        } elseif ($tokens[$j] === '{' || $tokens[$j] === ';') {
                            break;
                        }
                    }
                }

                if ($tokens[$i][0] === \T_CLASS) {
                    for ($j = $i + 1; $j < count($tokens); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                        if ($tokens[$j][0] === \T_STRING) {
                            $class = $tokens[$i + 2][1];
                            break 2;
                        }
                    }
                }
            }
        }

        if (!trim($class)) {
            return;
        }

        fclose($fp);

        return ltrim($namespace . '\\' . $class, '\\');
    }
}


1			<?php
2
3			namespace Phpactor\ClassFileConverter\Adapter\Simple;
4
5			/**
6			* Return the class name from a file.
7			*
8			* Based on http://stackoverflow.com/questions/7153000/get-class-name-from-file
9			*/
10			class ClassScanner
11			{
12			public function getClassNameFromFile($file)
13			{
14			$fp = fopen($file, 'r');
15
16			$class = $namespace = $buffer = '';
17			$i = 0;
18
19			while (!$class) {
20			if (feof($fp)) {
21			break;
22			}
23
24			// Read entire lines to prevent keyword truncation
25			for ($line = 0; $line <= 20; $line++) {
26			$buffer .= fgets($fp);
27			}
28			$tokens = @token_get_all($buffer);
29
30			if (strpos($buffer, '{') === false) {
31			continue;
32			}
33
34			for (; $i < count($tokens); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-01-01 16:22 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
35			if ($tokens[$i][0] === \T_NAMESPACE) {
36			for ($j = $i + 1; $j < count($tokens); $j++) {
			0 ignored issues – show Performance Best Practice introduced 2018-01-01 16:22 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
37			if ($tokens[$j][0] === T_STRING) {
38			$namespace .= '\\' . $tokens[$j][1];
39			} elseif ($tokens[$j] === '{' \|\| $tokens[$j] === ';') {
40			break;
41			}
42			}
43			}
44
45			if ($tokens[$i][0] === \T_CLASS) {
46			for ($j = $i + 1; $j < count($tokens); $j++) {
			0 ignored issues – show Performance Best Practice introduced 2018-01-01 16:22 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
47			if ($tokens[$j][0] === \T_STRING) {
48			$class = $tokens[$i + 2][1];
49			break 2;
50			}
51			}
52			}
53			}
54			}
55
56			if (!trim($class)) {
57			return;
58			}
59
60			fclose($fp);
61
62			return ltrim($namespace . '\\' . $class, '\\');
63			}
64			}
65

phpactor / class-to-file

Push — master ( 5db41f...c1280c )

ClassScanner::getClassNameFromFile() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like