| Conditions | 19 |
| Paths | 6 |
| Total Lines | 64 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public function getClassNameFromFile($file) |
||
| 15 | { |
||
| 16 | if (!file_exists($file)) { |
||
| 17 | return null; |
||
| 18 | } |
||
| 19 | |||
| 20 | $fp = fopen($file, 'r'); |
||
| 21 | |||
| 22 | if (false === $fp) { |
||
| 23 | throw new RuntimeException(sprintf( |
||
| 24 | 'Could not open file "%s"', |
||
| 25 | $file |
||
| 26 | )); |
||
| 27 | } |
||
| 28 | |||
| 29 | $class = $namespace = $buffer = ''; |
||
| 30 | $i = 0; |
||
| 31 | |||
| 32 | while (!$class) { |
||
| 33 | if (feof($fp)) { |
||
| 34 | break; |
||
| 35 | } |
||
| 36 | |||
| 37 | // Read entire lines to prevent keyword truncation |
||
| 38 | for ($line = 0; $line <= 20; $line++) { |
||
| 39 | $buffer .= fgets($fp); |
||
| 40 | } |
||
| 41 | $tokens = @token_get_all($buffer); |
||
| 42 | |||
| 43 | if (strpos($buffer, '{') === false) { |
||
| 44 | continue; |
||
| 45 | } |
||
| 46 | |||
| 47 | for (; $i < count($tokens); $i++) { |
||
|
|
|||
| 48 | if ($tokens[$i][0] === \T_NAMESPACE) { |
||
| 49 | for ($j = $i + 1; $j < count($tokens); $j++) { |
||
| 50 | if ($tokens[$j][0] === T_STRING) { |
||
| 51 | $namespace .= '\\' . $tokens[$j][1]; |
||
| 52 | } elseif ($tokens[$j] === '{' || $tokens[$j] === ';') { |
||
| 53 | break; |
||
| 54 | } |
||
| 55 | } |
||
| 56 | } |
||
| 57 | |||
| 58 | $token = $tokens[$i][0]; |
||
| 59 | if ($token === \T_INTERFACE || $token === \T_CLASS || $token === \T_TRAIT) { |
||
| 60 | for ($j = $i + 1; $j < count($tokens); $j++) { |
||
| 61 | if ($tokens[$j][0] === \T_STRING) { |
||
| 62 | $class = $tokens[$i + 2][1]; |
||
| 63 | break 2; |
||
| 64 | } |
||
| 65 | } |
||
| 66 | } |
||
| 67 | } |
||
| 68 | } |
||
| 69 | |||
| 70 | if (!trim($class)) { |
||
| 71 | return null; |
||
| 72 | } |
||
| 73 | |||
| 74 | fclose($fp); |
||
| 75 | |||
| 76 | return ltrim($namespace . '\\' . $class, '\\'); |
||
| 77 | } |
||
| 78 | } |
||
| 79 |
If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: