Ubiquity\orm\core\prepared\DAOPreparedQueryById

Complexity

Total Complexity

6

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	16	4
A	prepare()	0	5	1
A	__construct()	0	2	1

<?php

namespace Ubiquity\orm\core\prepared;

use Ubiquity\db\SqlUtils;
use Ubiquity\events\DAOEvents;
use Ubiquity\events\EventsManager;
use Ubiquity\orm\DAO;
use Ubiquity\orm\OrmUtils;

/**
 * Ubiquity\orm\core\prepared$DAOPreparedQueryOne
 * This class is part of Ubiquity
 *
 * @author jcheron <myaddressmail@gmail.com>
 * @version 1.0.0
 *
 */
class DAOPreparedQueryById extends DAOPreparedQuery {

	public function __construct($className, $included = false) {
		parent::__construct ( $className, '', $included );
	}

	protected function prepare() {
		parent::prepare ();
		$keys = OrmUtils::getKeyFields ( $this->className );
		$this->conditionParser->addKeyValues ( \array_fill ( 0, \count ( $keys ), '' ), $this->className );

It seems like $keys can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

		$this->conditionParser->limitOne ();
	}

	public function execute($params = [], $useCache = false) {
		$cp = $this->conditionParser;
		$cp->setKeyValues ( $params );
		$query = $this->db->prepareAndExecute ( $this->tableName, SqlUtils::checkWhere ( $cp->getCondition () ), $this->fieldList, $cp->getParams (), $useCache );
		if ($query && \sizeof ( $query ) > 0) {

The expression $query of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			$oneToManyQueries = [ ];
			$manyToOneQueries = [ ];
			$manyToManyParsers = [ ];
			$className = $this->className;
			$object = DAO::_loadObjectFromRow ( \current ( $query ), $className, $this->invertedJoinColumns, $manyToOneQueries, $this->oneToManyFields, $this->manyToManyFields, $oneToManyQueries, $manyToManyParsers, $this->accessors, $this->transformers );
			if ($this->hasIncluded) {
				DAO::_affectsRelationObjects ( $className, $this->firstPropKey, $manyToOneQueries, $oneToManyQueries, $manyToManyParsers, [ $object ], $this->included, $useCache );
			}
			EventsManager::trigger ( DAOEvents::GET_ONE, $object, $className );
		}
		return $object;

The variable $object does not seem to be defined for all execution paths leading up to this point.

	}
}