ApcuCache - Code Metrics - Inspection of "Cache sanitation" - phpMv/ubiquity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7c92dc...c428b0 )

by Jean-Christophe

created 2017-12-02 15:08 UTC

ApcuCache A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	13
c	0
b	0
f	0
lcom	1
cbo	1
dl	0
loc	83
rs	10

10 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	exists()	3	1
A	store()	3	1
A	storeContent()	3	1
A	getRealKey()	3	1
A	fetch()	4	1
A	file_get_contents()	3	1
A	getTimestamp()	15	4
A	remove()	3	1
A	clear()	3	1

<?php
namespace micro\cache\system;

/**
 * This class is responsible for storing Arrays in PHP files.
 */
class ApcuCache extends AbstractDataCache{
	/**
	 * Initializes the apcu cache-provider
	 */
	public function __construct($root,$postfix="") {
		parent::__construct($root,$postfix);
	}

	/**
	 * Check if annotation-data for the key has been stored.
	 * @param string $key cache key
	 * @return boolean true if data with the given key has been stored; otherwise false
	 */
	public function exists($key) {
		return \apcu_exists($this->getRealKey($key));

	}

	public function store($key, $code, $php=true) {
		$this->storeContent($key, $code);
	}

	/**
	 * Caches the given data with the given key.
	 * @param string $key cache key
	 * @param string $content the source-code to be cached
	 */
	protected function storeContent($key,$content) {
		\apcu_store($this->getRealKey($key), $content);
	}

	protected function getRealKey($key){
		return \md5($key);
	}

	/**
	 * Fetches data stored for the given key.
	 * @param string $key cache key
	 * @return mixed the cached data
	 */
	public function fetch($key) {
		$result=\apcu_fetch($this->getRealKey($key));
		return eval($result);

	}

	/**
	 * return data stored for the given key.
	 * @param string $key cache key
	 * @return mixed the cached data
	 */
	public function file_get_contents($key) {
		return \apcu_fetch($this->getRealKey($key));
	}

	/**
	 * Returns the timestamp of the last cache update for the given key.
	 *
	 * @param string $key cache key
	 * @return int unix timestamp
	 */
	public function getTimestamp($key) {
			$key=$this->getRealKey($key);
			$cache = \apc_cache_info();
			if (empty($cache['cache_list'])) {
				return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
			}
			foreach ($cache['cache_list'] as $entry) {
				if ($entry['info'] != $key) {
					continue;
				}
				$creationTime = $entry['creation_time'];
				return $creationTime;
			}
			return \time();
	}

	public function remove($key) {
		\apcu_delete($this->getRealKey($key));
	}

	public function clear() {
		\apcu_clear_cache();
	}
}


1			<?php
2			namespace micro\cache\system;
3
4			/**
5			* This class is responsible for storing Arrays in PHP files.
6			*/
7			class ApcuCache extends AbstractDataCache{
8			/**
9			* Initializes the apcu cache-provider
10			*/
11			public function __construct($root,$postfix="") {
12			parent::__construct($root,$postfix);
13			}
14
15			/**
16			* Check if annotation-data for the key has been stored.
17			* @param string $key cache key
18			* @return boolean true if data with the given key has been stored; otherwise false
19			*/
20			public function exists($key) {
21			return \apcu_exists($this->getRealKey($key));
			1 ignored issue – show Bug Compatibility introduced 2017-12-02 15:09 UTC by Report Bug Copy Issue Report The expression `\apcu_exists($this->getRealKey($key));` of type `boolean\|string[]` adds the type `string[]` to the return on line 21 which is incompatible with the return type declared by the abstract method `micro\cache\system\AbstractDataCache::exists` of type `boolean`. Loading history...
22			}
23
24			public function store($key, $code, $php=true) {
25			$this->storeContent($key, $code);
26			}
27
28			/**
29			* Caches the given data with the given key.
30			* @param string $key cache key
31			* @param string $content the source-code to be cached
32			*/
33			protected function storeContent($key,$content) {
34			\apcu_store($this->getRealKey($key), $content);
35			}
36
37			protected function getRealKey($key){
38			return \md5($key);
39			}
40
41			/**
42			* Fetches data stored for the given key.
43			* @param string $key cache key
44			* @return mixed the cached data
45			*/
46			public function fetch($key) {
47			$result=\apcu_fetch($this->getRealKey($key));
48			return eval($result);
			1 ignored issue – show Coding Style introduced 2017-12-02 03:12 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
49			}
50
51			/**
52			* return data stored for the given key.
53			* @param string $key cache key
54			* @return mixed the cached data
55			*/
56			public function file_get_contents($key) {
57			return \apcu_fetch($this->getRealKey($key));
58			}
59
60			/**
61			* Returns the timestamp of the last cache update for the given key.
62			*
63			* @param string $key cache key
64			* @return int unix timestamp
65			*/
66			public function getTimestamp($key) {
67			$key=$this->getRealKey($key);
68			$cache = \apc_cache_info();
69			if (empty($cache['cache_list'])) {
70			return false;
			1 ignored issue – show Bug Best Practice introduced 2017-12-02 15:09 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the abstract method `micro\cache\system\AbstractDataCache::getTimestamp` of type `integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
71			}
72			foreach ($cache['cache_list'] as $entry) {
73			if ($entry['info'] != $key) {
74			continue;
75			}
76			$creationTime = $entry['creation_time'];
77			return $creationTime;
78			}
79			return \time();
80			}
81
82			public function remove($key) {
83			\apcu_delete($this->getRealKey($key));
84			}
85
86			public function clear() {
87			\apcu_clear_cache();
88			}
89			}
90

phpMv / ubiquity

Push — master ( 7c92dc...c428b0 )

ApcuCache A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

Duplication Side-by-Side

Filter issues like