phpMv /
ubiquity
| Conditions | 12 |
| Paths | 12 |
| Total Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | public function validate($value) { |
||
| 23 | parent::validate($value); |
||
| 24 | $value = (string) $value; |
||
| 25 | |||
| 26 | switch ($this->ref) { |
||
| 27 | case Ip::V4: |
||
| 28 | $flag = FILTER_FLAG_IPV4; |
||
| 29 | break; |
||
| 30 | case Ip::V6: |
||
| 31 | $flag = FILTER_FLAG_IPV6; |
||
| 32 | break; |
||
| 33 | case Ip::V4_NO_PRIV: |
||
| 34 | $flag = FILTER_FLAG_IPV4 | FILTER_FLAG_NO_PRIV_RANGE; |
||
| 35 | break; |
||
| 36 | case Ip::V6_NO_PRIV: |
||
| 37 | $flag = FILTER_FLAG_IPV6 | FILTER_FLAG_NO_PRIV_RANGE; |
||
| 38 | break; |
||
| 39 | case Ip::ALL_NO_PRIV: |
||
| 40 | $flag = FILTER_FLAG_NO_PRIV_RANGE; |
||
| 41 | break; |
||
| 42 | case Ip::V4_NO_RES: |
||
| 43 | $flag = FILTER_FLAG_IPV4 | FILTER_FLAG_NO_RES_RANGE; |
||
| 44 | break; |
||
| 45 | case Ip::V6_NO_RES: |
||
| 46 | $flag = FILTER_FLAG_IPV6 | FILTER_FLAG_NO_RES_RANGE; |
||
| 47 | break; |
||
| 48 | case Ip::ALL_NO_RES: |
||
| 49 | $flag = FILTER_FLAG_NO_RES_RANGE; |
||
| 50 | break; |
||
| 51 | case Ip::V4_ONLY_PUBLIC: |
||
| 52 | $flag = FILTER_FLAG_IPV4 | FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE; |
||
| 53 | break; |
||
| 54 | case Ip::V6_ONLY_PUBLIC: |
||
| 55 | $flag = FILTER_FLAG_IPV6 | FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE; |
||
| 56 | break; |
||
| 57 | case Ip::ALL_ONLY_PUBLIC: |
||
| 58 | $flag = FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE; |
||
| 59 | break; |
||
| 60 | default: |
||
| 61 | $flag = null; |
||
| 62 | break; |
||
| 63 | } |
||
| 64 | |||
| 65 | return filter_var($value, FILTER_VALIDATE_IP, $flag); |
||
| 66 | } |
||
| 67 | |||
| 77 |
