Passed
Push — master ( 70ce04...9471d7 )
by Jean-Christophe
03:03
created

_affectsRelationObjects()   A

Complexity

Conditions 4
Paths 8

Size

Total Lines 13
Code Lines 10

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 7
CRAP Score 4.1755

Importance

Changes 0
Metric Value
cc 4
eloc 10
nc 8
nop 8
dl 0
loc 13
ccs 7
cts 9
cp 0.7778
crap 4.1755
rs 9.9332
c 0
b 0
f 0

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace Ubiquity\orm\traits;
4
5
use Ubiquity\orm\OrmUtils;
6
use Ubiquity\log\Logger;
7
use Ubiquity\orm\parser\Reflexion;
8
9
trait DAORelationsAssignmentsTrait {
10 5
	protected static function setToMember($member, $instance, $value, $accessor) {
11 5
		$instance->$accessor($value);
12 5
		$instance->_rest[$member]=$value;
13 5
	}
14
	
15 5
	protected static function getAccessor($member, $instance,$part) {
16 5
		$accessor="set" . ucfirst($member);
17 5
		if (method_exists($instance, $accessor)) {
18 5
			return $accessor;
19
		}
20
		$class=get_class($instance);
21
		Logger::warn("DAO", "Missing modifier " . $accessor . " in " . $class,$part);
22
		return false;
23
	}
24
	
25 4
	protected static function _affectsRelationObjects($className,$classPropKey,$manyToOneQueries,$oneToManyQueries,$manyToManyParsers,$objects,$included,$useCache){
26 4
		if(\sizeof($manyToOneQueries)>0){
27
			self::_affectsObjectsFromArray($manyToOneQueries,$included, function($object,$member,$manyToOneObjects,$fkField,$accessor){
28 4
				self::affectsManyToOneFromArray($object,$member,$manyToOneObjects,$fkField,$accessor);
29 4
			},'getManyToOne');
30
		}
31 4
		if(\sizeof($oneToManyQueries)>0){
32
			self::_affectsObjectsFromArray($oneToManyQueries,$included, function($object,$member,$relationObjects,$fkField,$accessor,$class,$prop) use ($classPropKey){
33
				self::affectsOneToManyFromArray($object,$member,$relationObjects,$fkField,$accessor,$class,$prop,$classPropKey);
34
			},'getOneToMany');
35
		}
36 4
		if(\sizeof($manyToManyParsers)>0){
37 4
			self::_affectsManyToManyObjectsFromArray($className,$manyToManyParsers, $objects,$included,$useCache);
38
		}
39 4
	}
40
	
41 4
	private static function affectsManyToOneFromArray($object,$member,$manyToOneObjects,$fkField,$accessor){
42 4
		if(isset($object->$fkField)){
43 4
			$value=$manyToOneObjects[$object->$fkField];
44 4
			self::setToMember($member, $object, $value, $accessor);
45
		}
46 4
	}
47
	
48
	/**
49
	 * @param object $instance
50
	 * @param string $member
51
	 * @param array $array
52
	 * @param string $mappedByAccessor
53
	 * @param string $class
54
	 * @param \ReflectionProperty $prop
55
	 */
56
	private static function affectsOneToManyFromArray($instance, $member, $array=null, $mappedByAccessor=null,$accessor="",$class="",$prop=null,$classPropKey=null) {
57
		$ret=[];
58
		self::_getOneToManyFromArray($ret,$array, Reflexion::getPropValue($instance,$classPropKey), $mappedByAccessor,$prop);
59
		self::setToMember($member, $instance, $ret, $accessor);
60
	}
61
	
62 4
	private static function _affectsObjectsFromArray($queries,$included,$affectsCallback,$part,$useCache=NULL){
63 4
		$includedNext=false;
64 4
		foreach ($queries as $key=>$pendingRelationsRequest){
65 4
			list($class,$member,$fkField)=\explode("|", $key);
66 4
			if(is_array($included)){
67
				$includedNext=self::_getIncludedNext($included, $member);
68
			}
69 4
			$objectsParsers=$pendingRelationsRequest->getObjectsConditionParsers();
70 4
			$prop=null;
71 4
			if('getOneToMany'===$part){
72
				$prop=OrmUtils::getFirstPropKey($class);
73
				$fkField="get" . ucfirst($fkField);
74
			}
75 4
			foreach ($objectsParsers as $objectsConditionParser){
76 4
				$objectsConditionParser->compileParts();
77 4
				$relationObjects=self::_getAll($class,$objectsConditionParser->getConditionParser(),$includedNext,$useCache);
78 4
				$objects=$objectsConditionParser->getObjects();
79 4
				if($accessor=self::getAccessor($member, current($objects), $part)){
80 4
					foreach ($objects as $object){
81 4
						$affectsCallback($object, $member,$relationObjects,$fkField,$accessor,$class,$prop);
82
					}
83
				}
84
			}
85
		}
86 4
	}
87
	
88 4
	private static function _affectsManyToManyObjectsFromArray($objectsClass,$parsers,$objects,$included,$useCache=NULL){
89 4
		$includedNext=false;
90 4
		$prop=OrmUtils::getFirstPropKey($objectsClass);
91 4
		foreach ($parsers as $key=>$parser){
92 4
			list($class,$member)=\explode("|", $key);
93 4
			if(is_array($included)){
94
				$includedNext=self::_getIncludedNext($included, $member);
95
			}
96 4
			$myPkValues=[];
97 4
			$cParser=self::generateManyToManyParser($parser, $myPkValues);
98 4
			$relationObjects=self::_getAll($class,$cParser,$includedNext,$useCache);
99 4
			if($accessor=self::getAccessor($member, current($objects), 'getManyToMany')){
100 4
				foreach ($objects as $object){
101 4
					$pkV=Reflexion::getPropValue($object, $prop);
102 4
					if(isset($myPkValues[$pkV])){
103 4
						$ret=self::getManyToManyFromArrayIds($class,$relationObjects, $myPkValues[$pkV]);
104 4
						self::setToMember($member, $object, $ret, $accessor);
105
					}
106
				}
107
			}
108
		}
109 4
	}
110
}
111
112