Completed
Push — master ( 499e80...f97bb0 )
by Jean-Christophe
01:49
created

YumlParser   B

Complexity

Total Complexity 50

Size/Duplication

Total Lines 190
Duplicated Lines 5.26 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
wmc 50
lcom 1
cbo 0
dl 10
loc 190
rs 8.6206
c 0
b 0
f 0

19 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A getFkName() 0 3 1
A parse() 0 8 2
A parsePart() 0 10 3
B parseAllProperties() 0 17 5
A parseProperties() 0 9 3
C parseProperty() 0 27 7
B getFirstKey() 6 10 5
A getFieldType() 0 7 3
A getPrimaryKeys() 4 8 4
A parseRelations() 0 7 1
A _parseRelations() 0 12 4
A parseManyRelations() 0 5 1
A _parseManyRelations() 0 21 4
A getParts() 0 3 1
A getTables() 0 3 1
A getTableNames() 0 3 1
A getFields() 0 3 1
A getForeignKeys() 0 5 2

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like YumlParser often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use YumlParser, and based on these observations, apply Extract Interface, too.

1
<?php
2
namespace Ubiquity\orm\creator\yuml;
3
4
5
class YumlParser {
6
	private $stereotypes=["pk"=>"«pk»","null"=>"«null»"];
7
	private $defaultType="varchar(30)";
8
	private $originalString;
9
	private $parts;
10
	private $tables=[];
11
12
	public function __construct($yumlString){
13
		$this->originalString=$yumlString;
14
		$this->parse();
15
	}
16
17
	private function getFkName($table,$prefix="id"){
18
		return $prefix.\ucfirst($table);
19
	}
20
	private function parse(){
21
		$str=$this->originalString;
22
		$this->parts=\preg_split('@\ *?,\ *?@', $str);
23
		foreach ($this->parts as $part){
24
			$this->parsePart($part);
25
		}
26
		$this->parseAllProperties();
27
	}
28
29
	private function parsePart($part){
30
		$matches=[];
31
		\preg_match_all('@\[\w+[\|\]]@', $part,$matches);
32
		if(\sizeof($matches[0])>0){
33
			foreach ($matches[0] as $match){
34
				$table=\substr($match,1, \strlen($match)-2);
35
				$this->tables[$table]=[];
36
			}
37
		}
38
	}
39
40
	private function parseAllProperties(){
41
		$tables=\array_keys($this->tables);
42
		foreach ($tables as $table){
43
			$matchProperties=[];
44
			\preg_match('@\['.$table.'\|(.*?)\]@', $this->originalString,$matchProperties);
45
			if(isset($matchProperties[1])){
46
				$properties=$matchProperties[1];
47
				$this->parseProperties($properties, $table);
48
			}
49
		}
50
		foreach ($tables as $table){
51
			$this->parseRelations($table);
52
		}
53
		foreach ($tables as $table){
54
			$this->parseManyRelations($table);
55
		}
56
	}
57
58
	private function parseProperties($propertiesString,$table){
59
		$properties=\explode(";", $propertiesString);
60
		foreach ($properties as $property){
61
			$result=$this->parseProperty($property);
62
			if(!isset($this->tables[$table]["properties"]))
63
				$this->tables[$table]["properties"]=[];
64
				$this->tables[$table]["properties"][]=$result;
65
		}
66
	}
67
68
	private function parseProperty($property){
69
		$matches=[];
70
		$result=[];
71
		\preg_match_all('@«(.+?)»@', $property,$matches);
72
		foreach ($matches as $match){
0 ignored issues
show
Bug introduced by
The expression $matches of type null|array<integer,array<integer,string>> is not guaranteed to be traversable. How about adding an additional type check?

There are different options of fixing this problem.

  1. If you want to be on the safe side, you can add an additional type-check:

    $collection = json_decode($data, true);
    if ( ! is_array($collection)) {
        throw new \RuntimeException('$collection must be an array.');
    }
    
    foreach ($collection as $item) { /** ... */ }
    
  2. If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:

    /** @var array $collection */
    $collection = json_decode($data, true);
    
    foreach ($collection as $item) { /** .. */ }
    
  3. Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.

Loading history...
73
			if(isset($match[0])){
74
				$property=\str_replace($match[0], "", $property);
75
				switch ($match[0]){
76
					case $this->stereotypes["pk"]:
77
						$result["pk"]=true;
78
						break;
79
					case $this->stereotypes["null"]:
80
						$result["null"]=true;
81
				}
82
			}
83
		}
84
		$parts=\explode(":", $property);
85
		\preg_match('@\ *?(\w+)@', $parts[0],$match);
86
		if(isset($match[1]))
87
			$result["name"]=$match[1];
88
		if(isset($parts[1])){
89
			$result["type"]=$parts[1];
90
		}else{
91
			$result["type"]=$this->defaultType;
92
		}
93
		return $result;
94
	}
95
96
	public function getFirstKey($table){
97
		$result=null;
98 View Code Duplication
		foreach ($this->tables[$table]["properties"] as $property){
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
99
			if(!isset($result))
100
				$result=$property["name"];
101
			if(isset($property["pk"]) && $property["pk"])
102
				return $property["name"];
103
		}
104
		return $result;
105
	}
106
107
	public function getFieldType($table,$fieldName){
108
		foreach ($this->tables[$table]["properties"] as $property){
109
			if($property["name"]===$fieldName)
110
				return $property["type"];
111
		}
112
		return null;
113
	}
114
115
	public function getPrimaryKeys($table){
116
		$result=[];
117 View Code Duplication
		foreach ($this->tables[$table]["properties"] as $property){
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
118
				if(isset($property["pk"]) && $property["pk"])
119
					$result[]=$property["name"];
120
		}
121
		return $result;
122
	}
123
124
	private function parseRelations($table){
125
		$matches=[];
126
		\preg_match_all('@\['.$table.'\][^,]*?1-.*?\[(\w+)\]@', $this->originalString,$matches);
127
		$this->_parseRelations($table, $matches);
128
		\preg_match_all('@\[(\w+)\].*?-[^,]*?1\['.$table.'\]@', $this->originalString,$matches);
129
		$this->_parseRelations($table, $matches);
130
	}
131
132
	private function _parseRelations($table,$matches){
133
		if(\sizeof($matches)>1){
134
			$pk=$this->getFirstKey($table);
135
			if(isset($pk)){
136
				foreach ($matches[1] as $match){
137
					$tableName=$match;
138
					$fk=$this->getFkName($table,$pk);
139
					$this->tables[$table]["relations"][]=["TABLE_NAME"=>$tableName,"COLUMN_NAME"=>$fk];
140
				}
141
			}
142
		}
143
	}
144
145
	private function parseManyRelations($table){
146
		$matches=[];
147
		\preg_match_all('@\['.$table.'\][^,]*?\*-.*?\*\[(\w+)\]@', $this->originalString,$matches);
148
		$this->_parseManyRelations($table, $matches);
149
	}
150
151
	private function _parseManyRelations($table,$matches){
152
		$myPk=$this->getFirstKey($table);
153
		$myFk=$this->getFkName($table,$myPk);
154
		$myFkType=$this->getFieldType($table, $myPk);
155
		if(\sizeof($matches)>1){
156
			foreach ($matches[1] as $match){
157
				$tableName=$match;
158
				$pk=$this->getFirstKey($tableName);
159
				if(isset($pk)){
160
					$fk=$this->getFkName($tableName,$pk);
161
					$fkType=$this->getFieldType($tableName, $pk);
162
					$newTable=$table."_".$tableName;
163
					$this->tables[$newTable]=[];
164
					$this->tables[$newTable]["properties"][]=["name"=>$myFk,"type"=>$myFkType,"pk"=>true];
165
					$this->tables[$newTable]["properties"][]=["name"=>$fk,"type"=>$fkType,"pk"=>true];
166
					$this->tables[$tableName]["relations"][]=["TABLE_NAME"=>$newTable,"COLUMN_NAME"=>$fk];
167
					$this->tables[$table]["relations"][]=["TABLE_NAME"=>$newTable,"COLUMN_NAME"=>$myFk];
168
				}
169
			}
170
		}
171
	}
172
	public function getParts(){
173
		return $this->parts;
174
	}
175
176
	public function getTables() {
177
		return $this->tables;
178
	}
179
180
	public function getTableNames(){
181
		return \array_keys($this->tables);
182
	}
183
184
	public function getFields($table){
185
		return $this->tables[$table]["properties"];
186
	}
187
188
	public function getForeignKeys($table){
189
		if(isset($this->tables[$table]["relations"]))
190
			return $this->tables[$table]["relations"];
191
		return [];
192
	}
193
194
}
195