Ubiquity\contents\validation\validators\Validator

Complexity

Total Complexity

16

Size/Duplication

Total Lines	84
Duplicated Lines	7.14 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	validate_()	0	9	2
A	setParams()	0	5	2
A	getMember()	0	3	1
A	setMember()	0	3	1
A	getParameters()	0	4	1
A	validate()	3	8	5
A	mergeMessages()	0	7	2
A	_getMessage()	3	8	2

<?php

namespace Ubiquity\contents\validation\validators;

use Ubiquity\utils\base\UString;
use Ubiquity\exceptions\ValidatorException;

abstract class Validator implements ValidatorInterface{
	protected $modifiedMessage;
	protected $message;
	protected $member;
	protected $value;
	protected $notNull;
	
	/**
	 * @param mixed $value
	 * @param string $member
	 * @param array $params
	 * @param string $severity
	 * @param string $message
	 * @return \Ubiquity\contents\validation\validators\ConstraintViolation|boolean
	 */
	public function validate_($value,$member,$params,$severity='warning',$message=null){
		$this->value=$value;
		$this->setParams($params);
		if(!$this->validate($value)){

The expression $this->validate($value) of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

			$this->modifiedMessage=$message;
			return new ConstraintViolation($this->_getMessage(), $value, $member, get_class($this),$severity);
		}
		return true;
	}
	
	protected function setParams(array $params){
		foreach ($params as $member=>$value){
			$this->$member=$value;
		}
	}
	
	/**
	 * @return mixed
	 */
	public function getMember() {
		return $this->member;
	}

	/**
	 * @param mixed $member
	 */
	public function setMember($member) {
		$this->member = $member;
	}
	
	/**
	 * {@inheritDoc}
	 * @see \Ubiquity\contents\validation\validators\ValidatorInterface::getParameters()
	 */
	public function getParameters(): array {
		return [];
		
	}
	
	public function validate($value) {
		if ($this->notNull!==false && (null === $value || '' === $value)) {

This code seems to be duplicated across your project.

			return;
		}
		if (!UString::isValid($value)) {
			throw new ValidatorException('This value can not be converted to string');
		}
	}
	
	/**
	 * @return array|string
	 */
	protected function mergeMessages(){
		if(!isset($this->modifiedMessage)){
			return $this->message;
		}else{
			return $this->modifiedMessage;
		}
	}
	
	protected function _getMessage(){
		$parameters=$this->getParameters();
		$message=$this->mergeMessages();
		foreach ($parameters as $param){
			$message=str_replace("{".$param."}", $this->$param, $message);
		}
		return $message;
	}

}