Completed
Push — master ( a6a009...27ae86 )
by Jean-Christophe
04:01
created

UFileSystem   B

Complexity

Total Complexity 40

Size/Duplication

Total Lines 139
Duplicated Lines 5.76 %

Coupling/Cohesion

Components 1
Dependencies 1

Importance

Changes 2
Bugs 1 Features 0
Metric Value
wmc 40
c 2
b 1
f 0
lcom 1
cbo 1
dl 8
loc 139
rs 8.2608

17 Methods

Rating   Name   Duplication   Size   Complexity  
A glob_recursive() 0 7 2
A deleteAllFilesFromFolder() 0 7 3
A deleteFile() 0 5 2
A safeMkdir() 0 5 2
A cleanPathname() 4 13 4
A cleanFilePathname() 4 10 3
A openReplaceInTemplateFile() 0 7 2
A openReplaceWriteFromTemplateFile() 0 6 2
A replaceFromTemplate() 0 8 2
A replaceWriteFromContent() 0 3 1
A tryToRequire() 0 7 2
A lastModified() 0 3 1
A load() 0 6 2
A save() 0 3 1
A getDirFromNamespace() 0 3 1
B xcopy() 0 20 7
A delTree() 0 7 3

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like UFileSystem often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use UFileSystem, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace Ubiquity\utils\base;
4
5
/**
6
 * File system utilities
7
 * @author jc
8
 * @version 1.0.0.2
9
 */
10
class UFileSystem {
11
12
	public static function glob_recursive($pattern, $flags=0) {
13
		$files=\glob($pattern, $flags);
14
		foreach ( \glob(\dirname($pattern) . '/*', GLOB_ONLYDIR | GLOB_NOSORT) as $dir ) {
15
			$files=\array_merge($files, self::glob_recursive($dir . '/' . \basename($pattern), $flags));
16
		}
17
		return $files;
18
	}
19
20
	public static function deleteAllFilesFromFolder($folder) {
21
		$files=\glob($folder . '/*');
22
		foreach ( $files as $file ) {
23
			if (\is_file($file))
24
				\unlink($file);
25
		}
26
	}
27
28
	public static function deleteFile($filename){
29
		if (\file_exists($filename))
30
			return \unlink($filename);
31
		return false;
32
	}
33
34
	public static function safeMkdir($dir) {
35
		if (!\is_dir($dir))
36
			return \mkdir($dir, 0777, true);
37
		return true;
38
	}
39
40
	public static function cleanPathname($path) {
41
		if (UString::isNotNull($path)) {
42 View Code Duplication
			if (DS === "/")
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
43
				$path=\str_replace("\\", DS, $path);
44
			else
45
				$path=\str_replace("/", DS, $path);
46
			$path=\str_replace(DS . DS, DS, $path);
47
			if (!UString::endswith($path, DS)) {
48
				$path=$path . DS;
49
			}
50
		}
51
		return $path;
52
	}
53
	
54
	public static function cleanFilePathname($path) {
55
		if (UString::isNotNull($path)) {
56 View Code Duplication
			if (DS === "/")
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
57
				$path=\str_replace("\\", DS, $path);
58
			else
59
				$path=\str_replace("/", DS, $path);
60
			$path=\str_replace(DS . DS, DS, $path);
61
		}
62
		return $path;
63
	}
64
65
	public static function openReplaceInTemplateFile($source, $keyAndValues) {
66
		if (\file_exists($source)) {
67
			$str=\file_get_contents($source);
68
			return self::replaceFromTemplate($str, $keyAndValues);
69
		}
70
		return false;
71
	}
72
73
	public static function openReplaceWriteFromTemplateFile($source, $destination, $keyAndValues) {
74
		if (($str=self::openReplaceInTemplateFile($source, $keyAndValues))) {
75
			return \file_put_contents($destination, $str, LOCK_EX);
76
		}
77
		return false;
78
	}
79
80
	public static function replaceFromTemplate($content, $keyAndValues) {
81
		array_walk($keyAndValues, function (&$item) {
82
			if (\is_array($item))
83
				$item=\implode("\n", $item);
84
		});
85
		$str=\str_replace(array_keys($keyAndValues), array_values($keyAndValues), $content);
86
		return $str;
87
	}
88
89
	public static function replaceWriteFromContent($content, $destination, $keyAndValues) {
90
		return \file_put_contents($destination, self::replaceFromTemplate($content, $keyAndValues), LOCK_EX);
91
	}
92
93
	public static function tryToRequire($file) {
94
		if (\file_exists($file)) {
95
			require_once ($file);
96
			return true;
97
		}
98
		return false;
99
	}
100
101
	public static function lastModified($filename) {
102
		return \filemtime($filename);
103
	}
104
105
	public static function load($filename){
106
		if (\file_exists($filename)) {
107
			return \file_get_contents($filename);
108
		}
109
		return false;
110
	}
111
112
	public static function save($filename,$content,$flags=LOCK_EX){
113
		return \file_put_contents($filename, $content, $flags);
114
	}
115
	
116
	public static function getDirFromNamespace($ns){
117
		return ROOT . DS . str_replace ( "\\", DS, $ns );
118
	}
119
	
120
	public static function xcopy($source, $dest, $permissions = 0755){
121
		if (is_link($source)) {
122
			return symlink(readlink($source), $dest);
123
		}
124
		if (is_file($source)) {
125
			return copy($source, $dest);
126
		}
127
		if (!is_dir($dest)) {
128
			mkdir($dest, $permissions,true);
129
		}
130
		$dir = dir($source);
131
		while (false !== $entry = $dir->read()) {
132
			if ($entry == '.' || $entry == '..') {
133
				continue;
134
			}
135
			self::xcopy("$source/$entry", "$dest/$entry", $permissions);
136
		}
137
		$dir->close();
138
		return true;
139
	}
140
	
141
	public static function delTree($dir) {
142
		$files = array_diff(scandir($dir), array('.','..'));
143
		foreach ($files as $file) {
144
			(is_dir("$dir/$file")) ? self::delTree("$dir/$file") : unlink("$dir/$file");
145
		}
146
		return rmdir($dir);
147
	}
148
}
149