Ubiquity\utils\flash\FlashBag

Complexity

Total Complexity

13

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	addMessage()	0	3	1
A	getMessages()	0	8	3
A	getAll()	0	3	1
A	clear()	0	3	1
A	rewind()	0	3	1
A	current()	0	3	1
A	key()	0	3	1
A	next()	0	3	1
A	valid()	0	3	1
A	save()	0	3	1

<?php

namespace Ubiquity\utils\flash;

use Ubiquity\utils\SessionUtils;

/**
 * Bag for Session Flash messages
 * @author jc
 *
 */
class FlashBag implements \Iterator{
	const FLASH_BAG_KEY="_flash_bag";
	private $array;
	private $position;
	public function __construct(){
		SessionUtils::start();
		$this->array=SessionUtils::get(self::FLASH_BAG_KEY, []);
	}

	public function addMessage($type,$content,$icon=NULL){
		$this->array[]=new FlashMessage($type, $content,$icon);
	}

	public function getMessages($type){
		$result=[];
		foreach ($this->array as $msg){

The expression $this->array of type array<integer,object<Ubiquity\utils\flash\FlashMessage>>|null is not guaranteed to be traversable. How about adding an additional type check?

			if($msg->getType()==$type)
				$result[]=$msg;
		}
		return $result;
	}

	public function getAll(){
		return $this->array;
	}

	public function clear(){
		SessionUtils::delete(self::FLASH_BAG_KEY);
	}
	public function rewind() {
		$this->position = 0;
	}

	public function current() {
		return $this->array[$this->position];
	}

	public function key() {
		return $this->position;
	}

	public function next() {
		++$this->position;
	}

	public function valid() {
		return isset($this->array[$this->position]);
	}

	public function save(){
		$this->array=SessionUtils::set(self::FLASH_BAG_KEY, $this->array);

Are you sure the assignment to $this->array is correct as \Ubiquity\utils\SessionUtils::set(self::FLASH_BAG_KEY, $this->array) (which targets Ubiquity\utils\SessionUtils::set()) seems to always return null.

	}

}