Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | abstract class AuthController extends ControllerBase{ |
||
| 19 | /** |
||
| 20 | * @var AuthFiles |
||
| 21 | */ |
||
| 22 | protected $authFiles; |
||
| 23 | protected $_controller; |
||
| 24 | protected $_action; |
||
| 25 | protected $_actionParams; |
||
| 26 | protected $_noAccessMsg; |
||
| 27 | protected $_loginCaption; |
||
| 28 | |||
| 29 | public function __construct(){ |
||
| 37 | |||
| 38 | public function index(){ |
||
| 44 | |||
| 45 | /** |
||
| 46 | * To override |
||
| 47 | * Return the base route for this Auth controller |
||
| 48 | * @return string |
||
| 49 | */ |
||
| 50 | public function _getBaseRoute(){ |
||
| 53 | /** |
||
| 54 | * {@inheritDoc} |
||
| 55 | * @see \controllers\ControllerBase::isValid() |
||
| 56 | */ |
||
| 57 | public final function isValid($action) { |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Action called when the user does not have access rights to a requested resource |
||
| 63 | * @param array|string $urlParts |
||
| 64 | */ |
||
| 65 | public function noAccess($urlParts){ |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Override for modifying the noAccess message |
||
| 78 | * @param FlashMessage $fMessage |
||
| 79 | */ |
||
| 80 | protected function noAccessMessage(FlashMessage $fMessage){ |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Override to implement the complete connection procedure |
||
| 86 | */ |
||
| 87 | public function connect(){ |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Processes the data posted by the login form |
||
| 99 | * Have to return the connected user instance |
||
| 100 | */ |
||
| 101 | abstract protected function _connect(); |
||
| 102 | |||
| 103 | /** |
||
| 104 | * @param object $connected |
||
| 105 | */ |
||
| 106 | abstract protected function onConnect($connected); |
||
| 107 | |||
| 108 | /** |
||
| 109 | * To override for defining a new action when creditentials are invalid |
||
| 110 | */ |
||
| 111 | protected function onBadCreditentials(){ |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Default Action for invalid creditentials |
||
| 117 | */ |
||
| 118 | View Code Duplication | public function badLogin(){ |
|
| 124 | |||
| 125 | /** |
||
| 126 | * To override for modifying the bad login message |
||
| 127 | * @param FlashMessage $fMessage |
||
| 128 | */ |
||
| 129 | protected function badLoginMessage(FlashMessage $fMessage){ |
||
| 132 | |||
| 133 | private function authLoadView($viewName,$vars=[]){ |
||
| 144 | |||
| 145 | /** |
||
| 146 | * Logout action |
||
| 147 | * Terminate the session and display a logout message |
||
| 148 | */ |
||
| 149 | View Code Duplication | public function terminate(){ |
|
| 156 | |||
| 157 | public function _disConnected(){ |
||
| 165 | |||
| 166 | /** |
||
| 167 | * To override for modifying the logout message |
||
| 168 | * @param FlashMessage $fMessage |
||
| 169 | */ |
||
| 170 | protected function terminateMessage(FlashMessage $fMessage){ |
||
| 173 | |||
| 174 | /** |
||
| 175 | * To override for modifying the disconnect message |
||
| 176 | * @param FlashMessage $fMessage |
||
| 177 | */ |
||
| 178 | protected function disconnectedMessage(FlashMessage $fMessage){ |
||
| 181 | |||
| 182 | /** |
||
| 183 | * Action displaying the logged user information |
||
| 184 | * if _displayInfoAsString returns true, use _infoUser var in views to display user info |
||
| 185 | * @return string|null |
||
| 186 | */ |
||
| 187 | public function info(){ |
||
| 190 | |||
| 191 | protected function fMessage(FlashMessage $fMessage){ |
||
| 194 | |||
| 195 | public function message($type,$header,$body,$icon="info"){ |
||
| 198 | |||
| 199 | protected function getOriginalURL(){ |
||
| 202 | |||
| 203 | /** |
||
| 204 | * To override for defining user session key, default : "activeUser" |
||
| 205 | * @return string |
||
| 206 | */ |
||
| 207 | public function _getUserSessionKey(){ |
||
| 210 | |||
| 211 | public function _checkConnection(){ |
||
| 215 | |||
| 216 | /** |
||
| 217 | * return boolean true if activeUser is valid |
||
| 218 | */ |
||
| 219 | abstract public function _isValidUser(); |
||
| 220 | |||
| 221 | /** |
||
| 222 | * To override for changing view files |
||
| 223 | * @return AuthFiles |
||
| 224 | */ |
||
| 225 | protected function getFiles ():AuthFiles{ |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Override to define if info is displayed as string |
||
| 231 | * if set to true, use _infoUser var in views to display user info |
||
| 232 | */ |
||
| 233 | public function _displayInfoAsString(){ |
||
| 236 | |||
| 237 | public function _checkConnectionTimeout(){ |
||
| 240 | |||
| 241 | private function _getFiles():AuthFiles{ |
||
| 247 | |||
| 248 | public function _getLoginInputName(){ |
||
| 251 | |||
| 252 | protected function loginLabel(){ |
||
| 255 | |||
| 256 | public function _getPasswordInputName(){ |
||
| 259 | |||
| 260 | protected function passwordLabel(){ |
||
| 263 | |||
| 264 | public function _getBodySelector(){ |
||
| 267 | |||
| 268 | /** |
||
| 269 | * Sets the default noAccess message |
||
| 270 | * Default : "You are not authorized to access the page <b>{url}</b> !" |
||
| 271 | * @param string $content |
||
| 272 | * @param string $title |
||
| 273 | * @param string $type |
||
| 274 | * @param string $icon |
||
| 275 | */ |
||
| 276 | public function _setNoAccessMsg($content,$title=NULL,$type=NULL,$icon=null) { |
||
| 279 | /** |
||
| 280 | * @param string $_loginCaption |
||
| 281 | */ |
||
| 282 | public function _setLoginCaption($_loginCaption) { |
||
| 285 | |||
| 286 | |||
| 287 | } |
||
| 288 |